unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Thien-Thi Nguyen <ttn@gnu.org>
To: Xue Fuqiao <xfq.free@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Cannot generate web manuals
Date: Sun, 29 Dec 2013 06:53:09 +0100	[thread overview]
Message-ID: <87wqio2ofu.fsf@zigzag.favinet> (raw)
In-Reply-To: <CAAF+z6EtDHu3-Fn60D_Dn7ENNu82VARBK0e5t6j5U6fC6tOqcQ@mail.gmail.com> (Xue Fuqiao's message of "Sun, 29 Dec 2013 12:04:59 +0800")

[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]

() Xue Fuqiao <xfq.free@gmail.com>
() Sun, 29 Dec 2013 12:04:59 +0800

   Maybe we should wrap it with something like
   `with-demoted-errors', or remove the erroneous `search-forward' line in
   `manual-html-fix-headers'.  Should I file a bug report?

Any fix that concerns only the ‘search-forward’ expression is not
desirable; we must not think of the code as absolutely wrong, but
instead, in what cases is it right and in what cases is it wrong.
To do that, we need to understand its function and its context.

It looks like the purpose of the fragment:

 (search-forward "<meta http-equiv=\"Content-Style")
 (setq opoint (match-beginning 0))
 (search-forward "</head>")
 (delete-region opoint (match-beginning 0))

is to delete that ‘meta’ element, so the best fix would be to not bother
trying to delete it if it's already not there.  Why haul water if there
is no fire?

-- 
Thien-Thi Nguyen
   GPG key: 4C807502
   (if you're human and you know it)
      read my lisp: (responsep (questions 'technical)
                               (not (via 'mailing-list)))
                     => nil

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2013-12-29  5:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-29  4:04 Cannot generate web manuals Xue Fuqiao
2013-12-29  5:53 ` Thien-Thi Nguyen [this message]
2013-12-29 15:43 ` Eli Zaretskii
2013-12-29 20:13 ` Glenn Morris
2013-12-29 23:32   ` Xue Fuqiao
2013-12-30  1:26     ` Glenn Morris
2013-12-30  3:47       ` Stephen J. Turnbull
2013-12-30 14:28       ` Xue Fuqiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wqio2ofu.fsf@zigzag.favinet \
    --to=ttn@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=xfq.free@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).