From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: Severe lossage from unread-command-events Date: Fri, 07 Aug 2015 18:41:25 +0200 Message-ID: <87wpx7hwzu.fsf@fencepost.gnu.org> References: <87egjh4u1h.fsf@fencepost.gnu.org> <83pp30sd5l.fsf@gnu.org> <87k2t831gf.fsf@fencepost.gnu.org> <83io8ssakw.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1438966060 5738 80.91.229.3 (7 Aug 2015 16:47:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 7 Aug 2015 16:47:40 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 07 18:47:30 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZNknp-00079D-Fj for ged-emacs-devel@m.gmane.org; Fri, 07 Aug 2015 18:47:29 +0200 Original-Received: from localhost ([::1]:49946 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNknp-00044n-12 for ged-emacs-devel@m.gmane.org; Fri, 07 Aug 2015 12:47:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNknk-00043e-RE for emacs-devel@gnu.org; Fri, 07 Aug 2015 12:47:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZNknf-0005tW-8I for emacs-devel@gnu.org; Fri, 07 Aug 2015 12:47:24 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:58386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNknf-0005tS-4k; Fri, 07 Aug 2015 12:47:19 -0400 Original-Received: from localhost ([127.0.0.1]:43186 helo=lola) by fencepost.gnu.org with esmtp (Exim 4.82) (envelope-from ) id 1ZNkne-0006Zm-7f; Fri, 07 Aug 2015 12:47:18 -0400 Original-Received: by lola (Postfix, from userid 1000) id 9B374E0C52; Fri, 7 Aug 2015 18:41:25 +0200 (CEST) In-Reply-To: (Stefan Monnier's message of "Fri, 07 Aug 2015 12:08:44 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188568 Archived-At: Stefan Monnier writes: >>> An element of the form (t . EVENT) forces EVENT to be added to that lis= t. >> This talks about a different kind of "recording", the one that stores >> keyboard input in this-command-keys. My changes don't touch that (at >> least I hope they don't ;-) > > I'm not sure it's really unrelated. The issue is that we don't want > events to be recorded twice if you "replay" them (i.e. do something > along the lines of (push (read-event) unread-command-events)). > >>> The code in keyboard.c is complex to a degree where I do not trust >>> myself to venture a guess regarding the nature of the right fix. > > This applies to everyone else as well :-( > >> > recording. Quite the nuisance. So I'll remove the t thing again and >> > will see how I fare then. > > I think you need to use "the t thing" since your events aren't replays. According to the DOC string, I would be inclined to think so (it's very hard to tell what the effect of doing or not doing so would be, and it also seems to match the actual code rather loosely at best). But Emacs does not complain when I don't. And it breaks macro recording when I=A0do. And nobody else working with unread-command-events appears to be doing it, either. --=20 David Kastrup