From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: Calling Lisp from undo.c's record_* functions Date: Thu, 19 Nov 2015 10:16:43 +0000 Message-ID: <87wpte8fas.fsf@russet.org.uk> References: <83r3jpc2of.fsf@gnu.org> <87h9kkbz6k.fsf@russet.org.uk> <838u5wbmvu.fsf@gnu.org> <83ziyc9zs0.fsf@gnu.org> <83wptg9dcd.fsf@gnu.org> <87610zsd3u.fsf@russet.org.uk> <83io4z9ozx.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1447928228 19534 80.91.229.3 (19 Nov 2015 10:17:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Nov 2015 10:17:08 +0000 (UTC) Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 19 11:17:07 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZzMH4-0006GR-1T for ged-emacs-devel@m.gmane.org; Thu, 19 Nov 2015 11:17:06 +0100 Original-Received: from localhost ([::1]:40623 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzMH3-0007pf-Ew for ged-emacs-devel@m.gmane.org; Thu, 19 Nov 2015 05:17:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55999) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzMGp-0007pZ-T4 for emacs-devel@gnu.org; Thu, 19 Nov 2015 05:16:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzMGo-0005FP-Sv for emacs-devel@gnu.org; Thu, 19 Nov 2015 05:16:51 -0500 Original-Received: from cheviot22.ncl.ac.uk ([128.240.234.22]:44383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzMGk-0005DO-3b; Thu, 19 Nov 2015 05:16:46 -0500 Original-Received: from smtpauth-vm.ncl.ac.uk ([10.8.233.129] helo=smtpauth.ncl.ac.uk) by cheviot22.ncl.ac.uk with esmtp (Exim 4.63) (envelope-from ) id 1ZzMGi-00077I-DH; Thu, 19 Nov 2015 10:16:44 +0000 Original-Received: from jangai.ncl.ac.uk ([10.66.67.223] helo=localhost) by smtpauth.ncl.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1ZzMGh-00069Y-To; Thu, 19 Nov 2015 10:16:43 +0000 In-Reply-To: <83io4z9ozx.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 18 Nov 2015 19:49:38 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 128.240.234.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194779 Archived-At: Eli Zaretskii writes: >> From: phillip.lord@russet.org.uk (Phillip Lord) >> Cc: Stefan Monnier , >> Date: Wed, 18 Nov 2015 12:31:33 +0000 >> >> > But if an idle timer is fine, I think Phillip already has everyuthing >> > sorted out on a branch. >> >> Not entirely. Either the idle timer runs all the time (which Stefan >> doesn't like), or we only run it once (which missed the case when a >> process runs). > > Really? IOW, an idle timer doesn't run when we have read something > from a subprocess, and return to the waiting loop? I would expect the > idle timers to run in that situation. You've misunderstood. Emacs idle timers run when the user is idle, not emacs! Can you test this branch for me, and see if you can reproduce the error. fix/segfault-undoable-change-prepare-for-buffer This leaves the implementation as was, but moves the run_undoable_change call to prepare_for_change_1. Phil