dbus.el and use-dialog-box

dbus.el and use-dialog-box

[Mario Lang]

Hi.

It appears that `yes-or-no-p' when called from a D-Bus
method handler honors `use-dialog-box'.  In other words, when
`use-dialog-box' is non-nil, `yes-or-no-p' uses a dialog to ask the
question.
The docstring of `use-dialog-box' only refers to mouse events:

"Non-nil means mouse commands use dialog boxes to ask questions.
This applies to `y-or-n-p' and `yes-or-no-p' questions asked by commands
invoked by mouse clicks and mouse menu items."

Is this expected behaviour, or should D-Bus events be excluded
(from the check in Fyes_or_no_p?)

-- 
CYa,
  ⡍⠁⠗⠊⠕

Re: dbus.el and use-dialog-box

[Michael Albinus]

Mario Lang <mlang@delysid.org> writes:

> Hi.

Hi Mario,

> It appears that `yes-or-no-p' when called from a D-Bus
> method handler honors `use-dialog-box'.  In other words, when
> `use-dialog-box' is non-nil, `yes-or-no-p' uses a dialog to ask the
> question.

Yes. I suspect this would also be the case for file notification events
(not tested) and other special events.

> The docstring of `use-dialog-box' only refers to mouse events:
>
> "Non-nil means mouse commands use dialog boxes to ask questions.
> This applies to `y-or-n-p' and `yes-or-no-p' questions asked by commands
> invoked by mouse clicks and mouse menu items."
>
> Is this expected behaviour, or should D-Bus events be excluded
> (from the check in Fyes_or_no_p?)

If you have a look on Fyes_or_no_p, there is no dedicated check for
mouse events. The check reads

  if ((NILP (last_nonmenu_event) || CONSP (last_nonmenu_event))
      && use_dialog_box && ! NILP (last_input_event))

A similar check, using last_nonmenu_event and use_dialog_box, is applied
also in other functions, like Fmessage_or_box and
Fnext_read_file_uses_dialog_p. A cons cell in last_nonmenu_event is
regarded as mouse event, but this isn't true any longer for years. Any
special event represented as cons cell will match.

It might not be the designed behaviour, but I find it natural. Everybody
who dislikes this could configure use-dialog-box So I propose to
document this behaviour in the said three functions as well as in
use_dialog_box, replacing "mouse events" by "special events".

Best regards, Michael.

Re: dbus.el and use-dialog-box

[Stefan Monnier]

> use_dialog_box, replacing "mouse events" by "special events".

"special events" is pretty vague.  I'd prefer something like
"non-keyboard events".


        Stefan

Re: dbus.el and use-dialog-box

[Michael Albinus]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> use_dialog_box, replacing "mouse events" by "special events".
>
> "special events" is pretty vague.  I'd prefer something like
> "non-keyboard events".

This term was inspired by `special-event-map'. But "non-keyboard events"
is OK for me.

>         Stefan

Best regards, Michael.