From: Stephen Berman <stephen.berman@gmx.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Some testing issues
Date: Sat, 08 Jul 2017 16:52:24 +0200 [thread overview]
Message-ID: <87wp7jnfpz.fsf@rosalinde> (raw)
In-Reply-To: <jwv8tjzh71l.fsf-monnier+gmane.emacs.devel@gnu.org> (Stefan Monnier's message of "Sat, 08 Jul 2017 00:45:10 -0400")
On Sat, 08 Jul 2017 00:45:10 -0400 Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> Several of the tests call the function todo-toggle-view-done-items,
>> which contains this code:
>>
>> (if (not (pos-visible-in-window-p shown))
>> (recenter)
>
> This code is indeed brittle: pos-visible-in-window-p presumes that
> (current-buffer) is the same as (window-buffer (selected-window)), but
> that's not always the case.
Is there a less brittle way to test the visibility of point? At least
as far as using todo-toggle-view-done-items in todo-mode in concerned,
(current-buffer) is equivalent to (window-buffer (selected-window)), but
apparently that is not so in the test environment.
Steve Berman
next prev parent reply other threads:[~2017-07-08 14:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 21:22 Some testing issues Stephen Berman
2017-07-08 4:20 ` Noam Postavsky
2017-07-08 14:50 ` Stephen Berman
2017-07-08 22:01 ` Noam Postavsky
2017-07-14 9:55 ` Stephen Berman
2017-07-08 4:45 ` Stefan Monnier
2017-07-08 14:52 ` Stephen Berman [this message]
2017-07-10 17:33 ` Stefan Monnier
2017-07-14 9:56 ` Stephen Berman
2017-07-14 13:44 ` Stefan Monnier
2017-07-17 10:02 ` Stephen Berman
2017-07-17 18:22 ` Stefan Monnier
2017-07-08 7:18 ` martin rudalics
2017-07-08 14:51 ` Stephen Berman
2017-07-09 7:46 ` martin rudalics
2017-07-14 9:55 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp7jnfpz.fsf@rosalinde \
--to=stephen.berman@gmx.net \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).