From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: What's the right way to detect libxml2? Date: Fri, 03 Nov 2017 18:17:44 +0100 Message-ID: <87wp37i8nb.fsf@gmail.com> References: <7f80cde1944261b7ee29020ff953f14c.squirrel@cloud103.planethippo.com> <36e54d52-99b2-ae53-2b36-99d06eb53d15@gmail.com> <877evkfpe1.fsf@gmail.com> <873767fp1p.fsf@gmail.com> <83wp3f63jk.fsf@gnu.org> <87d155aul2.fsf@gmail.com> <831slfwvp5.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1509729473 1470 195.159.176.226 (3 Nov 2017 17:17:53 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 3 Nov 2017 17:17:53 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 03 18:17:49 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAfbI-0008R7-QC for ged-emacs-devel@m.gmane.org; Fri, 03 Nov 2017 18:17:48 +0100 Original-Received: from localhost ([::1]:37754 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAfbQ-0005Wc-A3 for ged-emacs-devel@m.gmane.org; Fri, 03 Nov 2017 13:17:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAfbK-0005WX-3o for emacs-devel@gnu.org; Fri, 03 Nov 2017 13:17:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAfbJ-0002oH-12 for emacs-devel@gnu.org; Fri, 03 Nov 2017 13:17:50 -0400 Original-Received: from mail-wm0-x22f.google.com ([2a00:1450:400c:c09::22f]:52235) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eAfbI-0002no-Pb; Fri, 03 Nov 2017 13:17:48 -0400 Original-Received: by mail-wm0-x22f.google.com with SMTP id t139so3009230wmt.1; Fri, 03 Nov 2017 10:17:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:user-agent:mime-version; bh=UAS9WyBc2iSLoL2CiLN0/leyhCwTpIW3eWzArJ8dI5o=; b=n5qP/UKc2jWS7U6n3GVUVkV+dHioUsGDCeRR9MMyvMoTdox0NZl1UIqEH1tkPF8Gfy /RYZkaSvMXeZ3pSdgYX2jIt2cFiXeEQeGfgfNYb3cNry1wAC7s7wVW0OYGCf9csjaHDE Jji6FcZb4oO8fkQAHyn6zTxBXmStjJMJ4CK+0xUVK50JAnTwkBreCjLICMSJrzAp2ll6 j3oeU1SQKRxgvxOJovQSyny86F4wKBa2P0dbZS953iF1UXbakFtzp2PnELDi28sHLtr3 8Kilv8K3PFqJbAI42EAdeWlzyXJCbu0/aakABI0Q+OenwlLzSbBcTyaxE3Q/oQr1bFpC DtMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version; bh=UAS9WyBc2iSLoL2CiLN0/leyhCwTpIW3eWzArJ8dI5o=; b=md5wBmqtqWSJ7ljptT2g7Kj8JxU5hZCCe+DahbReKuFZ6Pldeh3l8KAKzA8WIfNM7w VlmA/4fFFHl5J1et710szvpbwcbdJcEKqDb5XnCufFngDjnXgeqGHuNcBeB83pensSwW rjGXEj5rgQ9FDUbH87T+RNglmuDM6j3npdr2/lxnfOTDd+Z2SGrkOp7LKxnGZGuouEfV JUbXSG6HGRDRcESIGxcU/EzoMZ8w/Ziz2zmbpxucFuNWO4gMYInB5u1CUHdLX5HXt2B4 oYIfOY9WY1+oNSiv627eccSBUqI57siGnQLJyRD8ejdJK5SSn+WLrcoKPjaf8rbYnu22 xjOw== X-Gm-Message-State: AMCzsaU3Ud/YgcKDR4eKZiA8kHaNCv6+HNv1m05FbP2aBkVkVctMGbHI yS3dh32Jr5+fXjjhL6rkKsURCZI6 X-Google-Smtp-Source: ABhQp+ScmB9n4NY5ve8GWFp3ghMPIvJZq4sANt8D0oyzJy3ddN1hV22aoHqC9ChtS36XaMwQbyHTPg== X-Received: by 10.80.144.104 with SMTP id z37mr9788139edz.23.1509729467103; Fri, 03 Nov 2017 10:17:47 -0700 (PDT) Original-Received: from rpluim-ubuntu ([2a01:e34:ecfc:a090:7953:2f3f:a304:7ee1]) by smtp.gmail.com with ESMTPSA id v15sm2121414edb.24.2017.11.03.10.17.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Nov 2017 10:17:45 -0700 (PDT) Gmane-Reply-To-List: yes In-Reply-To: <831slfwvp5.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 03 Nov 2017 11:36:06 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219894 Archived-At: Eli Zaretskii writes: >> From: Robert Pluim >> Cc: andrewjmoreton@gmail.com, emacs-devel@gnu.org >> Date: Mon, 30 Oct 2017 09:49:45 +0100 >> >> > This is okay for the master branch, but please also add a NEWS entry >> > about the new function, and the fact that from now on the detection of >> > libxml2 availability should use that. >> >> Attached, as I don't have commit privileges, and I don't know whether >> my copyright assignment has finished being processed yet. > > Thanks, pushed to the master branch. > > A comment for the future: please always end the log en tries with a > period, to make them complete sentences. Like this: > > * src/xml.c (Flibxml_available_p): New function, cloned from > Fgnutls_available_p. > (syms_of_xml): Provide Slibxml_available_p. I tend to use the full stop as a separator rather than a terminator, but I'll adjust for Emacs. Robert