Re: (bisected) Bug in callint.c/bytecomp.el

Re: (bisected) Bug in callint.c/bytecomp.el

[Noam Postavsky]

On Sat, Jan 6, 2018 at 10:02 PM, Ioan-Adrian Ratiu <adi@adirat.com> wrote:

> ce48658191 Fix command repetition with lexical-binding (Bug#29334)
>
> I don't have the deep understanding required to properly fix this so I
> just reverted ce48658191 and my problems went away :)
>
> Can someone more knowledgeable please attempt a proper fix?

I'm not sure exactly what the proper fix would be, I've just gone
ahead and reverted that change.

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=29988#11

(bisected) Bug in callint.c/bytecomp.el

[Ioan-Adrian Ratiu]

Hello

I'm getting the following error on latest master if I run for eg. describe-symbol:

condition-case: Symbol’s function definition is void: internal-make-closure

toggle-debug-on-error results in:

Debugger entered--Lisp error: (void-function internal-make-closure)
  (internal-make-closure (x) (v-or-f) nil (funcall (nth 1 x) (internal-get-closed-var 0)))
  (cl-some (internal-make-closure (x) (v-or-f) nil (funcall (nth 1 x) (internal-get-closed-var 0))) describe-symbol-backends)
  (if v-or-f (cl-some (internal-make-closure (x) (v-or-f) nil (funcall (nth 1 x) (internal-get-closed-var 0))) describe-symbol-backends))
  (let* ((v-or-f (symbol-at-point)) (found (if v-or-f (cl-some (internal-make-closure (x) (v-or-f) nil (funcall (nth 1 x) (internal-get-closed-var 0))) describe-symbol-backends))) (v-or-f (if found v-or-f (function-called-at-point))) (found (or found v-or-f)) (enable-recursive-minibuffers t) (val (completing-read (if found (format "Describe symbol (default %s): " v-or-f) "Describe symbol: ") obarray (function (lambda (vv) (cl-some (internal-make-closure (x) (vv) nil (funcall (nth 1 x) (internal-get-closed-var 0))) describe-symbol-backends))) t nil nil (if found (symbol-name v-or-f))))) (list (if (equal val "") v-or-f (intern val))))
  call-interactively(describe-symbol nil nil)
  command-execute(describe-symbol)

I bisected it to the following commit:

ce48658191 Fix command repetition with lexical-binding (Bug#29334)

I don't have the deep understanding required to properly fix this so I
just reverted ce48658191 and my problems went away :)

Can someone more knowledgeable please attempt a proper fix?

Thank you

Re: (bisected) Bug in callint.c/bytecomp.el

[Ioan-Adrian Ratiu]

On Sat, 06 Jan 2018, Noam Postavsky <npostavs@users.sourceforge.net> wrote:
> On Sat, Jan 6, 2018 at 10:02 PM, Ioan-Adrian Ratiu <adi@adirat.com> wrote:
>
>> ce48658191 Fix command repetition with lexical-binding (Bug#29334)
>>
>> I don't have the deep understanding required to properly fix this so I
>> just reverted ce48658191 and my problems went away :)
>>
>> Can someone more knowledgeable please attempt a proper fix?
>
> I'm not sure exactly what the proper fix would be, I've just gone
> ahead and reverted that change.
>
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=29988#11

Works for me. Thanks!