Re: [PATCH] Support custom 'null' and 'false' objects when parsing JSON

["João Távora" <joaotavora@gmail.com>]

Eli Zaretskii <eliz@gnu.org> writes:

> Some comments on the documentation parts:

Thanks!

>> +The value decides which Lisp object use to represent the JSON keyword
> "to use"

Done.

>
>> +@code{null}.  It defaults to the lisp symbol @code{:null}.
>> +The value decides which Lisp object use to represent the JSON keyword
> Likewise.

Duh-ne

> Btw, I think @table..@end table will produce a better-looking output
> here.

OK.

>> +Lisp string.  The arguments @var{args} are a list of keyword/argument
>                                           ^^^^^^^^^^
> "is a list"

Note "The arguments".  I was struggling with how to phrase this so I
copied from process.texi:617

   The arguments @var{args} are a list of keyword/argument pairs.

I suppose you prefer "the argument @var{args} is a list", so I changed
it accordingly.

>> +@item @code{:object-type}
>
> Doesn't this duplicate the same list above?

Not quite.  json-parse-string accepts one more argument, object-type,
which json-serialize doesn't.  So while I could refactor the common
part, I think it's not quite worth it yet.

>If so, it would be best to have only one copy of that.  (And you have
>the same issues as above with omitting "to" in "to use".)

Argh. ETOOMANYTOOS

> IOW, use a semi-colon between alternatives, which will then allow you
> to use commas freely when describing each alternative.

OK. Good alternative.

>> +can recursively contain the lisp equivalents to the JSON null and
> "Lisp"
>> +The lisp equivalents to the JSON null and false values are
> Likewise.

OK.

>> +Note that ambiguity can arise if you specify the same value for
>> +`:null-object' and `:false-object', and so this function's behaviour
>> +is unspecified
> Missing period at end of sentence.

I changed the sentence altogether (and added the period). I think we can
safely specify that output will not contain any JSON false.

Thanks again for reviewing.
Pushed a new version to scratch/allow-custom-null-and-false-objects-in-jsonc

João