From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: Introducing thread-safe Tramp Date: Sat, 28 Jul 2018 12:13:05 +0200 Message-ID: <87wotfhdn2.fsf@gmx.de> References: <8736wa9c5s.fsf@gmx.de> <3e63b230-6cc1-f517-da71-57b892e14e30@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1532772674 14652 195.159.176.226 (28 Jul 2018 10:11:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 28 Jul 2018 10:11:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 28 12:11:10 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjMBp-0003iE-L5 for ged-emacs-devel@m.gmane.org; Sat, 28 Jul 2018 12:11:09 +0200 Original-Received: from localhost ([::1]:44560 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjMDw-0000zU-Bs for ged-emacs-devel@m.gmane.org; Sat, 28 Jul 2018 06:13:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjMDp-0000zL-RF for emacs-devel@gnu.org; Sat, 28 Jul 2018 06:13:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjMDk-0002ir-Ua for emacs-devel@gnu.org; Sat, 28 Jul 2018 06:13:13 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:47723) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fjMDk-0002hK-L6 for emacs-devel@gnu.org; Sat, 28 Jul 2018 06:13:08 -0400 Original-Received: from detlef.gmx.de ([79.140.121.82]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MdXSC-1fK1L506Y8-00PKhf; Sat, 28 Jul 2018 12:13:07 +0200 In-Reply-To: <3e63b230-6cc1-f517-da71-57b892e14e30@yandex.ru> (Dmitry Gutov's message of "Sat, 28 Jul 2018 12:59:41 +0300") X-Provags-ID: V03:K1:GT7DeKy7CAVreDFgv/AYgMvNt/OoE8TEKDv9KkHUiWsjjXs+FMY l5n2TIaK4/YWi40Z9hMBZfbgIERnu6YuDwClx5SBpTD1isg9HqGapaYDiy6ywfMZ4FmcPur YU/Lp5ZODHMG+88T/0nx4x5duPdzoZ2ua0yqT8uG2hyQZ+pBoSDTpPHpBDZyee7mzVg0GYK dyKPDYi8t7BbGqOqDmw5w== X-UI-Out-Filterresults: notjunk:1;V01:K0:+cC4QjbqQIw=:tk5+q+bfn34YAEWt+wFDGa OsAwuUt+6OEUVqWjN0GKjk73JKcDRavDeRCoDwL0qR1idcAuWkQ8ShgkAepQfO7D7jSODh44N LrgJwbnqs9eFOxAhpt2Fo8BkhZffGnNlPeD8bSvThVdsKKbQ2s9NEPzeVD/1xpFcCXAVYcm72 wWpxdoTL7qlY+lcewq8gaCwwSyBSZG7n8Q/4oUrgTKtnKDFg5FBf3lJTxdAAqK12h1o1M5djs s2Eo66Jw5jBNMkfNEa2Qw7ESrP9Qyf4ZEfrBhYGAGCNQS8qM3KPZqALUGSygTpgcpTtXOeVzp dmXk+RhABPLVX7AoMoS8X9Y0rIbBhwuWxaAtovS3SIn3TO6sKmceJtU1KnHQO6UP0SZS626ZY PqvE4xQ4NKGKG2GYlbaozMpzxFb/MTN/Y6YL1jRAtjEzKnhPklxzMflw+qFGxnikLolAg3FVA swbPLdLplh5GzO9oErj6w3qf+67uFAuIxXkTFvutlo5Hcc847TRxl49xtHW59sQxbtTSdsueg xKX79zgdHgbYZdx8oBj5UsBF6/dN4379ozUu6XqkD/hFOUb2NV42tFNlLB+pxPPK2XNYbE1fs ghhwis8usxsn2Z8vHcvqULa7sfyruoXWaeLTsIzeshu8uB1PALZwzYWP0kjZkJuZaZ5ferWnW /U5Sncq8H5QxquixrCTECrBkkCWqHeMfmSLaxB4OFkMNNygTkORW3NkjgMYYk/c1w/dAGF/qL QGVZrQdzWLfVwdK6mWf8W1/vQKrmdUCZb5rPNNuvzzi4nG0YefcuwQY6pRng9uSWgQEPapa/ X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.17.21 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227917 Archived-At: Dmitry Gutov writes: > No objections from me in principle, but we should probably call > vc-file-clearprops right away (is there a chance that some other code > calls vc-state before this thread launches and gets stale status?). I've scanned the Emacs lisp dir, and there doesn't seem to be any other call to vc-state. If I'm not mistaken. > We could also make vc-state use the same mutex, in order for it to > wait until refresh finished, instead of returning the stale result. Well, you are much more experienced with vc than I do. Look at the changes I've done in vc-hooks.el, and adapt. The only other relevant change I've done is, that I lock the vc-mutex in find-file-with-threads of files.el. This reorders the threads, all vc-refresh-state calls are performed after all files (from a wildcard) are loaded into their respective buffers. This improves early visibility of the visited files. Best regards, Michael.