From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel,gmane.emacs.orgmode Subject: Re: orgalist-mode: wrong indentation in message mode after recent change in emacs Date: Tue, 23 Apr 2019 11:53:02 +0100 Message-ID: <87wojldmcx.fsf@tcd.ie> References: <87k1gdptsn.fsf@len.workgroup> <87ef6l9x13.fsf@tcd.ie> <87a7ghw2tc.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="180978"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Stefan Monnier , emacs-devel@gnu.org To: emacs-orgmode@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 23 13:01:16 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hItAk-000kp2-7u for ged-emacs-devel@m.gmane.org; Tue, 23 Apr 2019 13:01:10 +0200 Original-Received: from localhost ([127.0.0.1]:51713 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hItAj-0007aY-4L for ged-emacs-devel@m.gmane.org; Tue, 23 Apr 2019 07:01:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hItAS-0007IV-Cc for emacs-devel@gnu.org; Tue, 23 Apr 2019 07:00:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIt2w-0003nS-PK for emacs-devel@gnu.org; Tue, 23 Apr 2019 06:53:08 -0400 Original-Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:44433) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hIt2w-0003mf-96 for emacs-devel@gnu.org; Tue, 23 Apr 2019 06:53:06 -0400 Original-Received: by mail-ed1-x535.google.com with SMTP id i13so12168864edf.11 for ; Tue, 23 Apr 2019 03:53:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=a2hZ9qoX99sq3Hx8SHVHhntc8j+1CQDWJ5pHmaL24fQ=; b=Fo5kfLyAvbnVqbklCFPvg/Bay1G0cX+zyhAj0VA/c85+h/N4VJNLPykH8txEEizvnD 0SMdns08sZTWA1IsQPdX9ozEh710h+UAY4fmN5jacrAb9qrq9N8AmUEvsoe8axe5XFCU UdXGj+fqJrmlMdO6ZSYRuXvUe/nb6q2Is1f/PRELGD0SYdUJZF43DsBV6sHJGVYH6SBo QbKTxpU0JEDvJAujyBn7eCPUhDkRekppzEw69UvTePN7y8J/xpK7OyeDyGyuZ0bXDAOC VW9KtGywVBsgnuHC7AkT/IRFUnidxe7zNwhkuh0P5r/Tq6MQYwjFjWggl/5eJVZaWY4n DFDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=a2hZ9qoX99sq3Hx8SHVHhntc8j+1CQDWJ5pHmaL24fQ=; b=FE+B6s7WGudDZ4qYoC57kKEVEHTPpjmcbUahkxJR+Hrq+qCrOA29kU8eaOCNcR2sTE xr8/V2OPI0WKpIh1EQSR+Jr5mQVVE2Bi7xlvwH8KfXsURQb8ehDCeXZTxEmINJhr4acW 50IQsRphTiz5RA/lpYBRWN/6fPBu7XcpoSoY8Nz5DrFIOQyQhw7sxsQnlZE0C0nEyTry XtA4qhPHyyv7kXti0mBLgFEO5/A32wQKHLvwf8sCTF3sqNU4/fvPXhRQ0Hj1ePk2SG2u fKlrXVe2crJeShljM/fvWF+RXTEPZbN8C1pyyqmpxLkdG39KFMq3ssGwlYnefqqlnLtT S0tg== X-Gm-Message-State: APjAAAXlU0T9ir8Xtoxs96TQ1PqhU5Kr6cPMnToOyeZ7toB2IhvDyqSo IyBQEUNFhhvaN0lOegBPJHYge2OGkP0r8A== X-Google-Smtp-Source: APXvYqzyCxcTU8Mfs339/dTILRQlpJEj+cetElnGSzOZXvq1+ow626MCWgcaJmCPGRCFxAYjkzawZg== X-Received: by 2002:a17:906:af84:: with SMTP id mj4mr12316509ejb.32.1556016784561; Tue, 23 Apr 2019 03:53:04 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:8f5:8e00:4345:7c72]) by smtp.gmail.com with ESMTPSA id j55sm4615755ede.73.2019.04.23.03.53.03 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 23 Apr 2019 03:53:03 -0700 (PDT) In-Reply-To: <87a7ghw2tc.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Tue, 23 Apr 2019 10:20:15 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::535 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235809 gmane.emacs.orgmode:124242 Archived-At: Nicolas Goaziou writes: > "Basil L. Contovounesios" writes: > >> The first is whether orgalist-mode couldn't use a custom >> indent-line-function instead of advising what may or may not be set to >> indent-relative by the user. > > I don't know how that would work in practice. Me neither. > But a minor mode taking control over `indent-line-function' sounds > wrong. Well, orgalist already "takes control" over indent-line-function and indent-according-to-mode via advice, and the latter advice seems to assume that indent-line-function is set to the default indent-relative or indent-relative-first-indent-point. >> The second is why advice--buffer-local does what it does. Stefan, why >> does it behave differently depending on local-variable-p? Why can't it >> simply call make-local-variable before returning the symbol-value? >> >> The third is why indent-according-to-mode hard-codes the check for >> indent-relative and indent-relative-first-indent-point. Wouldn't it be >> nice if this check instead looked up some variable akin to >> electric-indent-functions-without-reindent, that can be more easily >> customised? > > So what is the current status of this? Do I still need to add > a workaround around a workaround around a genuine Emacs bug? :) Yes. :) I think the patch I proposed in my previous email should be applied to orgalist, as a first step at the very least. Thanks, -- Basil