From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [RFE] Migration to gitlab Date: Sat, 11 May 2019 20:25:25 +0100 Message-ID: <87woiwx07u.fsf@tcd.ie> References: <87imwhmmt8.fsf@gmail.com> <87y347g1l3.fsf@iotcl.com> <9ac21e82-8e47-f9b5-f88d-23c0c56946d1@yandex.ru> <87pnpc1lby.fsf@iotcl.com> <83zhoezdqc.fsf@gnu.org> <87imuivfcr.fsf@iotcl.com> <83k1eyfxls.fsf@gnu.org> <17D21056-10B2-4813-AE90-9B2706936CE9@icloud.com> <83imuifqjc.fsf@gnu.org> <87lfzehrug.fsf@gmail.com> <20190511021206.GA4049@ACM> <83ef55eapl.fsf@gnu.org> <83bm09e2ce.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="6645"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, monnier@iro.umontreal.ca, =?utf-8?B?7KGw7ISx67mI?= , dgutov@yandex.ru, acm@muc.de, toon@iotcl.com, agrambot@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 11 21:26:41 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hPXdo-0001ck-CW for ged-emacs-devel@m.gmane.org; Sat, 11 May 2019 21:26:40 +0200 Original-Received: from localhost ([127.0.0.1]:34505 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPXdn-0006lU-D6 for ged-emacs-devel@m.gmane.org; Sat, 11 May 2019 15:26:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPXct-0006iH-2O for emacs-devel@gnu.org; Sat, 11 May 2019 15:25:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hPXck-0005v9-JZ for emacs-devel@gnu.org; Sat, 11 May 2019 15:25:36 -0400 Original-Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]:43497) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hPXck-0005jd-3r for emacs-devel@gnu.org; Sat, 11 May 2019 15:25:34 -0400 Original-Received: by mail-ed1-x542.google.com with SMTP id w33so10516525edb.10 for ; Sat, 11 May 2019 12:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=K590B7jOa1CWVuEz5Hx37O7n7Fzae71GMdGbGI2cG9g=; b=NxOztrJcWD/6xsF7iBm5/vQMn8Y8xSaaPAnGHW0D3BeFErZOLuj4d0B5EXVZJSUWjU GBWz0FHFvjkXRZOnwa+s3MQtgNBEtHMuy5Y4R5tg/dBZNpgvJmdKPYHzLDjlRwmSBR91 P3LKSwW3VFOMPNEqiVhRiWGHkEasND7QfFi4jzYxu6kBeLmigVsjXDOl6gkobHgdMIDA JGb47WctGayT+/0uDQBBXHLPYwXpb0xYB7GsE7jP/uEaHxU7prgE5ZsPtXUMOZqhNp9R 05Z/seSK+LNrAhdnlE8ZQqlW0G1nvmjt/+Zujc52KTzVQIzHNmILIDxj2MPlyRTOAINk zVOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=K590B7jOa1CWVuEz5Hx37O7n7Fzae71GMdGbGI2cG9g=; b=S9rxhqFwEuzZjZELx5dn4JE4B6m+sBQfX0Pcx24ciVvSj43SZrQp8JMVeNoiwIhtt7 eVnmOD1emo+mOWJYtmflWQY7svR/iLq+VN+6wV7pDQ0giQBl0NQY+Dbul+HJw5AKK1KM jEUeoYYfLZZKoz1j4IOvVa41elIIMYsoh/Z0/42Ezvm7tpGxVtrWvDMDRoBvu2s7k3ea 6ORAVmaaUh7fwmMUWrArQNN5OQiulmatyc6n7baoytJV28+KS1H2UKXoCQLjFN2Wyn4t W+sA1laChlnqX783pFBnvVzjJFjaNU46bpeePQZk1mvP+nDell9d68/TeF/FABgXMIMn XiVw== X-Gm-Message-State: APjAAAXeGTn9fXo4umS4i7yWlGHGMK59Z1ylVTRYZln2lhWX7Y2+1gFH dP0L+eG7lMB0njb99f7ENhdLkA== X-Google-Smtp-Source: APXvYqwSHP5GVViU+a3xLr2UZdd0WvqxI+wxMbPmrkwVpyq9puOiu1FOAYeJW+xxKLwApRZUF4QZPw== X-Received: by 2002:a50:b4f7:: with SMTP id x52mr20114605edd.190.1557602726968; Sat, 11 May 2019 12:25:26 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:8cad:ae29:555d:852d]) by smtp.gmail.com with ESMTPSA id m12sm1229349ejr.19.2019.05.11.12.25.26 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 11 May 2019 12:25:26 -0700 (PDT) In-Reply-To: <83bm09e2ce.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 11 May 2019 13:02:09 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::542 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236442 Archived-At: Eli Zaretskii writes: >> From: =EC=A1=B0=EC=84=B1=EB=B9=88 >> Date: Sat, 11 May 2019 16:38:30 +0900 >> Cc: emacs-devel@gnu.org, monnier@iro.umontreal.ca, dgutov@yandex.ru, >> acm@muc.de, toon@iotcl.com, agrambot@gmail.com >>=20 >> If you=E2=80=99re saying commit messages, you can view them and ask the = contributors >> to fix the messages, rebase the commits, and force-push them. You can me= rge >> them afterwards. > > Asking the contributors to fix the log messages works only up to some > not very far limit. Quite frequently, IME, the 2nd, the 3rd, and > sometimes the 4th attempt are still not what I'd like to see, whether > due to misunderstanding or something else. At which point I usually > give up and fix the rest myself, so as not to discourage the > contributor the next time he/she wants to contribute. > > Force-push is normally not an option, as our repository disallows > that, to avoid someone's mistake corrupting the repository or losing > data. > > So there should be an easy way of accepting a PR/MR where I can > augment the log message in the process. Because once the commit is > pushed, whatever deficiencies there were in the log message are carved > in stone forever. I'm not sure if GitLab has added this feature yet, but GitHub pull request submissions include a checkbox (default on) to allow the project's maintainers to edit the pull request. This means they are allowed to push (forcefully or otherwise) changes to the submitter's non-master branch before merging the pull request. I don't find this a particularly "nice" way to work by default (so I'm not advocating it), but I thought I'd mention it for completeness. Thanks, --=20 Basil