From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Gramiak Newsgroups: gmane.emacs.devel Subject: Re: Removing the usage of X structures (or their names) in independent code Date: Mon, 13 May 2019 10:15:53 -0600 Message-ID: <87woiugwjq.fsf@gmail.com> References: <875zqkdzfc.fsf@gmail.com> <83d0ksgo1h.fsf@gnu.org> <87woizd263.fsf@gmail.com> <8336lnh7rw.fsf@gnu.org> <87d0kpilww.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="259621"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 13 18:16:56 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQDdH-0015Oo-Lk for ged-emacs-devel@m.gmane.org; Mon, 13 May 2019 18:16:55 +0200 Original-Received: from localhost ([127.0.0.1]:60042 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQDdG-0007iQ-G2 for ged-emacs-devel@m.gmane.org; Mon, 13 May 2019 12:16:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQDcO-0007hz-CC for emacs-devel@gnu.org; Mon, 13 May 2019 12:16:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQDcN-0006wu-5L for emacs-devel@gnu.org; Mon, 13 May 2019 12:16:00 -0400 Original-Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]:38759) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQDcM-0006vZ-TM; Mon, 13 May 2019 12:15:59 -0400 Original-Received: by mail-pl1-x633.google.com with SMTP id f97so1618569plb.5; Mon, 13 May 2019 09:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XaWT7jsvN4dRtofq/bt2K2G/u8+aeHO+j72xlrSj2WU=; b=sG0iKm5clSit8KFIdfaxhs7BpjE0915gwlB7ooZOd1/7YO14azaABNwN4457wgRYpn JEPkdZ3+qClqjqMBoNZlEcoaMOt75SCEey0H0ZKfdKLurL0IB0hpQ0wBCwsLh0GMuc75 mU7v465D1Zy5jfgb7jPXNH1T/xftAnaE86LzYOe8FncpgKNe8U8nyq+E5I8vGID3cdlF sYGubmPsGaeqY9jebrHltTOpbNzGpxIzQggEFSK/xNXFJnq8I93PVz5GbVp1xocPyBaZ 3VWm17nPeGgwM7qn3m6PooLOIVJKMYOAwxbjZYuEA9HBiysKYCtaIbajESM/wtkgfbbe 1QbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=XaWT7jsvN4dRtofq/bt2K2G/u8+aeHO+j72xlrSj2WU=; b=AqH1r9ET/ZXhHVlPGCtRrrkux5o7wQEC5fg+6BsyvBDPlOjJldzGb2IuDxmPHF4pTg 12gPFodLuV6R6wdLsGKzU7kL6bvAVFFXdBMB8xuVx5fnpwCa0GVwTHe9fXzGu066ZWfm CD4u3A2ZYkv3ipY2KLdwHKanbgGF1hlhvRUBWszA9wW34Cd/wqjqxLNNYGv6exuQx9yw i8F2ASa+hh346fJY6JyZiz6BbZmqf5ytSR9yT+/a7zJoPxhO30b2Ko9UDUzO+vW3E89q MA7wREvOCHNvA2QpKmQ1ZSAPnnkRvwVCo/eQ/f4SvxriszNtpAPcWHbWqlFDk0i8TGwk ti+g== X-Gm-Message-State: APjAAAWj19ANzVg01ElR9zMj7mAN/pzBwadHbaAP0WUDR5TiS5Gb3QbH x086uDgqQoJ09s8+UY8+gScRycd8 X-Google-Smtp-Source: APXvYqyhEm86S1Z/9Wj+wZN4KuZeZZRsdUvLaxNCwkJmAxuSj5f4sGF/lQBP/9eagVh8vP8qqZLu3Q== X-Received: by 2002:a17:902:da4:: with SMTP id 33mr31689205plv.20.1557764156750; Mon, 13 May 2019 09:15:56 -0700 (PDT) Original-Received: from lylat ([2604:3d09:e37f:1500:1a72:4878:e793:7302]) by smtp.gmail.com with ESMTPSA id p81sm20159565pfa.26.2019.05.13.09.15.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 May 2019 09:15:55 -0700 (PDT) In-Reply-To: <87d0kpilww.fsf@gmail.com> (Alex Gramiak's message of "Fri, 10 May 2019 23:45:51 -0600") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::633 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236466 Archived-At: Alex Gramiak writes: > I posted a patch series to the scratch/X_Typedefs branch. WDYT? > > The first few patches are straightforward, but the XChar2b patch is a > bit more involved. > > Regarding the last patch, I don't like the names Emacs_Pix_Container > (XImagePtr) and Emacs_Pix_Context (XImagePtr_or_DC), but I'm lost as to > better names. > > AFAIU XImage is a client-side structure holding bitmap/pixmap data[1]. > My first thought was "Emacs_Pixmap_Container", but that would be easily > confused for a container for Emacs_Pixmap. At least the abbreviation > dissociates the two structures a bit. > > [1] https://tronche.com/gui/x/xlib/graphics/images.html Ping. Any comments? I'd like to merge this branch to master.