From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Simplify Gnus buffer liveness checking and killing Date: Mon, 20 May 2019 14:43:56 -0700 Message-ID: <87woikx0mb.fsf@ericabrahamsen.net> References: <87ef4uq92p.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="36899"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 20 23:52:57 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hSqDI-0009UA-QJ for ged-emacs-devel@m.gmane.org; Mon, 20 May 2019 23:52:56 +0200 Original-Received: from localhost ([127.0.0.1]:42474 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSqDH-0004b6-PT for ged-emacs-devel@m.gmane.org; Mon, 20 May 2019 17:52:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSq4l-0007Ws-1a for emacs-devel@gnu.org; Mon, 20 May 2019 17:44:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSq4k-0000EY-1w for emacs-devel@gnu.org; Mon, 20 May 2019 17:44:07 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:37828 helo=mail.ericabrahamsen.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hSq4j-000090-UM for emacs-devel@gnu.org; Mon, 20 May 2019 17:44:06 -0400 Original-Received: from localhost (50-251-205-17-static.hfc.comcastbusiness.net [50.251.205.17]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id D95C1FA345; Mon, 20 May 2019 21:43:57 +0000 (UTC) In-Reply-To: <87ef4uq92p.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 20 May 2019 01:10:54 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 52.70.2.18 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236822 Archived-At: "Basil L. Contovounesios" writes: > There seems to be overlap in the implementations and usage of > gnus-buffer-exists-p and gnus-buffer-live-p, as well as of gnus-buffers > and gnus-prune-buffers. > > The attached patch removes gnus-buffer-exists-p in favour of a modified > gnus-buffer-live-p, aliases gnus-prune-buffers to a simplified > gnus-buffers, and simplifies several call sites pertaining to buffer > liveness checking and killing. WDYT? I've been running this most of today; nothing terrible has happened so far. Can I suggest adding `gnus-buffer-exists-p' back in as a `define-obsolete-function-alias' for `gnus-buffer-live-p'? I assume that will work for macros. Anyway, it would just be nicer for people who, ahem, have external packages that were using that function. Thanks, Eric