From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Enable persistent naming for tabs Date: Sun, 27 Oct 2019 00:46:36 +0300 Organization: LINKOV.NET Message-ID: <87wocruqmb.fsf@mail.linkov.net> References: <87r23lpg22.fsf@cochranmail.com> <871rvktgyj.fsf@mail.linkov.net> <87ftjz6v4d.fsf@cochranmail.com> <87lftoiwfl.fsf@mail.linkov.net> <87eez7la3v.fsf@mail.linkov.net> <878spddbpj.fsf@mail.linkov.net> <87eez3xwi1.fsf@cochranmail.com> <87ftjjfb4h.fsf@mail.linkov.net> <87r230akt8.fsf@cochranmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="242239"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org, "T.V Raman" To: Robert Cochran Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 27 00:36:32 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iOUff-0010lb-Aq for ged-emacs-devel@m.gmane.org; Sun, 27 Oct 2019 00:36:31 +0200 Original-Received: from localhost ([::1]:43276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOUfe-0000hA-26 for ged-emacs-devel@m.gmane.org; Sat, 26 Oct 2019 18:36:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33964) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOTvA-0007mp-RH for emacs-devel@gnu.org; Sat, 26 Oct 2019 17:48:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iOTv9-0002lz-Ci for emacs-devel@gnu.org; Sat, 26 Oct 2019 17:48:28 -0400 Original-Received: from crocodile.birch.relay.mailchannels.net ([23.83.209.45]:60579) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iOTv8-0002lY-U6 for emacs-devel@gnu.org; Sat, 26 Oct 2019 17:48:27 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 22A9F5E0EA5; Sat, 26 Oct 2019 21:48:24 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a85.g.dreamhost.com (100-96-8-64.trex.outbound.svc.cluster.local [100.96.8.64]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id B02065E00C7; Sat, 26 Oct 2019 21:48:23 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a85.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Sat, 26 Oct 2019 21:48:24 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Bottle-Squirrel: 553020ab4ee2ffcc_1572126503935_2998472166 X-MC-Loop-Signature: 1572126503935:801685769 X-MC-Ingress-Time: 1572126503935 Original-Received: from pdx1-sub0-mail-a85.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a85.g.dreamhost.com (Postfix) with ESMTP id 72BBC7FF38; Sat, 26 Oct 2019 14:48:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=ZwkeTmBdN0Ttr8+B8ylaqQ2odQM=; b= K6C/64cNIVwQ/jpzVj++QZxbBJVBjWG6YDwaRcxKuawvcbo4aPHZ5flrfSsXQo23 5StIyWuknQCgjPPlBR8m162JxW8VMSFXqjZkGuXH9bkPfxD3sTSw5KPGCN6nzZdb FGa7vPXJgG9QzClZ6CE49OncnlPrCz4wJPyH3D635KA= Original-Received: from mail.jurta.org (m91-129-98-153.cust.tele2.ee [91.129.98.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a85.g.dreamhost.com (Postfix) with ESMTPSA id 6833D7FF37; Sat, 26 Oct 2019 14:48:15 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a85 In-Reply-To: <87r230akt8.fsf@cochranmail.com> (Robert Cochran's message of "Fri, 25 Oct 2019 08:47:47 -0700") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 23.83.209.45 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241486 Archived-At: >>> C) Disable tab-bar-mode >> >> While implementing tab closing undo, I added disabling tab-bar-mode >> because it was easier to just add this line: >> >> (or (<= (length tabs) 1) ; closed the last tab >> >> But please remove this from the default behavior because > > Sorry, I didn't quite understand what you wanted me to do there, so I > didn't try to address it. I see that you already resolved this after rebasing. Thanks! Now your patch is pushed to master without merge conflicts. >> I noticed that it disables tab-bar on all frames, whereas >> it would make more sense to disable tab-bar only on the >> selected frame. I meant we could have separate tab-bar-mode to disable it only on the selected frame, and global-tab-bar-mode to disable it globally on all frames. > It occurred to me in the process of writing this up that it might be > useful to provide hook variables for creating and closing tabs - > 'tab-bar-tab-open-hook' and 'tab-bar-tab-close-hook' perhaps? Standard > fare on those - a list of functions that take the tab as an argument, > probably called as the last task of tab creation and the first task of > tab closing? Thoughts? Not sure if this could be a hook on tab-bar basic events, or a customizable function. Also not clear whether to call it before or after the main body. We need to collect more examples of use cases to decide on the implementation.