From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: Fix for bug #39344 (Gnus selecting deleted buffer) incomplete. Date: Wed, 29 Jan 2020 11:57:27 -0600 Message-ID: <87wo9a87so.fsf@red-bean.com> References: <87o8umdwow.fsf@red-bean.com> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="80181"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Emacs Devel To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 29 18:58:11 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iwrbP-000KSx-33 for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Jan 2020 18:58:11 +0100 Original-Received: from localhost ([::1]:49688 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwrbO-0007Sx-5P for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Jan 2020 12:58:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40707) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwram-0006h7-EZ for emacs-devel@gnu.org; Wed, 29 Jan 2020 12:57:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iwrak-00035n-9l for emacs-devel@gnu.org; Wed, 29 Jan 2020 12:57:32 -0500 Original-Received: from mail-yb1-xb44.google.com ([2607:f8b0:4864:20::b44]:42327) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iwrak-00034i-3p for emacs-devel@gnu.org; Wed, 29 Jan 2020 12:57:30 -0500 Original-Received: by mail-yb1-xb44.google.com with SMTP id z125so264207ybf.9 for ; Wed, 29 Jan 2020 09:57:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:reply-to:date:in-reply-to :message-id:user-agent:mime-version; bh=4xjAta1u1dPstRjry4XT/7Pn/w4bGpCfQg9XzN7sZYA=; b=DTo3atRiJYOQ9TO491S/g6TzZIhmodYbkuqDOtmoHVHAq1s5p8cquFy4aW7Ex8eELs SWI869smNSM5DEJ3e31LWxOPsvcKDCn5V49VbulWE7r75hfmH6ZeCr7RdN+dltbftQt2 UGzXjNjrLB9XWxjnIkJskb3BwY1RiHK/YxCwkqDXVwNwDWLfYw0NQyFcIYhnKgGjxDNB 8+z0me9dzoBDak8TuFMEqrdojCiVvQNEOM85MJlFqfKKC0wPPI+cyy3tqK91B9XVLUW4 19wcMheptC35MCUqu9qLoUO/iBUFAKcftdo8pTP4TPkKcpM8dd0gbtF8M8rTfps/Ihjg S5sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:reply-to :date:in-reply-to:message-id:user-agent:mime-version; bh=4xjAta1u1dPstRjry4XT/7Pn/w4bGpCfQg9XzN7sZYA=; b=TjIGnx+hrAa6YAxgUikBZTTqKzCJwPhWsjaE4DadJTkdLCbZBC4NtziXRKjzV7aC2+ EUxM4WmvKC7Orf5yRUpOnVY7Bxe9zJSvaQKHa7MfvzIvDV6iDkT5thbWhaPRmOjpNziI AuD6oJWQ94Es0Gne8SadI1tQF2zVPrCS9VAXPh9qb/EJ0UiI0hLS75NS/mQ49VuX1gO6 ixCE6Oe7xuWKeBgs/XEuLlyTx/nXpEaf6juxbgfSCPkZ71QBEXzHv5N3SojMj7jhAZmm B6XKoQAOG+2za/NVEeUJI1GD2MI8h6rtmSFiLC7/HF+q8LIYr6Dt67Jb3BSkINvJWcUf TZqg== X-Gm-Message-State: APjAAAVCRfw/tlBSCtuZuSNl7VHKhd4UJ8znlt95Rprpkk+KDHVSoJFp gQ7DscWs8Ai7wUHDjTAkReMbjLOt X-Google-Smtp-Source: APXvYqwV6OUexe3IHNlnB8uEQIv2T821EiTlezqeBPgjDhdscY1cXA6jO1aVdqVN9JszixDkIUG8FQ== X-Received: by 2002:a25:cc4f:: with SMTP id l76mr535060ybf.327.1580320649206; Wed, 29 Jan 2020 09:57:29 -0800 (PST) Original-Received: from kwork (c-67-173-70-191.hsd1.il.comcast.net. [67.173.70.191]) by smtp.gmail.com with ESMTPSA id e187sm1224305ywd.7.2020.01.29.09.57.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jan 2020 09:57:28 -0800 (PST) In-Reply-To: (Andreas Schwab's message of "Wed, 29 Jan 2020 18:11:54 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::b44 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:244753 Archived-At: On 29 Jan 2020, Andreas Schwab wrote: >On Jan 29 2020, Karl Fogel wrote: > >> After some debugging, I still don't know why the bug remains, though I've >> learned a lot about Gnus buffer management, so that's nice. My guess is >> that this problem is related to earlier commit 5ee3c37634f, in which many >> functions in Gnus were changed to use `gnus-get-buffer-create' and thus >> now store the created buffer in in `gnus-buffers'. > >But it adds only new buffers to gnus-buffers, so that it cannot create >duplicates. Well, yes, that makes sense to me too but occasionally I get surprised by an unexpected side effect in Emacs. However, I think Sam's commit bb3b0990d really did fix bug#39344 after all. I did a *full* rebuild this time, i.e., $ make distclean && ./autogen.sh && ./configure && make bootstrap and now the bug is gone. Previously I had just done a plain 'make', after 'git pull' into a just-built tree had pulled down exactly that one change from Sam. Probably the persistence of the buggy behavior was an artifact of the quick build process. Best regards, -Karl