From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: 31395511: =?utf-8?Q?=22Don=E2=80=99t?= attempt to modify constant strings" Date: Thu, 04 Jun 2020 00:08:58 +0100 Message-ID: <87wo4niw6t.fsf@tcd.ie> References: <871rmvn7ge.fsf@gmail.com> <87lfl36abx.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="3825"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Paul Eggert , =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= , emacs-devel@gnu.org To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 04 01:09:45 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jgcW1-0000vT-5m for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Jun 2020 01:09:45 +0200 Original-Received: from localhost ([::1]:54948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgcW0-0002OY-8B for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Jun 2020 19:09:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgcVL-0001mn-8U for emacs-devel@gnu.org; Wed, 03 Jun 2020 19:09:03 -0400 Original-Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:44150) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jgcVK-00074X-38 for emacs-devel@gnu.org; Wed, 03 Jun 2020 19:09:02 -0400 Original-Received: by mail-wr1-x42a.google.com with SMTP id y17so4067641wrn.11 for ; Wed, 03 Jun 2020 16:09:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=npSnuCPJmgBx0MJ/MquP5EzBJXPlm3Kv++aeXiWXDTU=; b=Iys32LgG0MF9eJHzH7289qxEaHZDbZEsQvci/QYAFcSUZjZiiiU4jIHbTk0bKdg9E6 PPLhKQi/OMjkMJt8zl0+QuIgBg1T2U5Ij0VbPrvixn7qkX3Xg5qCGtaBmP3mPnSAJQua kX3ZqZTfv+PjL3sRtJhqxWh59t5nFcyrqxEywAT2VZvZKKXwABdilm0odyiEbbS4bezT ZQopdgWqgdtmcNQluoQuLOOkxoD4cSrvN4kIUlYlINp0zpQ1kMAbYXXqQ7CLviUU7rGs Rm81xX0g3LdPtjRLY7GYIJprRjuqDhDn2Wb3cTLfP8uaWhqiSxN5WJaPKcaAEmZ2Nt3O GyIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=npSnuCPJmgBx0MJ/MquP5EzBJXPlm3Kv++aeXiWXDTU=; b=aaWHeMm+gA6KYpL7ZMu/i95rERoHSh7ec8+llaILNpyG/RmHNg29bt28CIH48G2t4U hZJE80UtWawldelLr1zbDAKwdrWI1H+DHlrT7qsLTXIbNd5Hbyl/NTbHzlsSYh82+iMR YG6oXdSNkgOkSmHJkLzN3LbWoAxByckCutMY8Si9c1hEFm7HHQ3POoeqHLCIIFQlqS83 d/S5IO6JyzBQXaDcmRyZYoUmFg4JZtjbeemtcvCItsODxr4MK3DiywIabU90vcTkaDFf vpKFjeSoJkdYOyhRw4THQEKSUMJn+gHi+yOfWEkmvgHkKQkWDLHbkxtEBhnMHWXO/l++ IOPw== X-Gm-Message-State: AOAM532F0Np3QpP/FC1NKErIeZkowYmj12FunqeqYudVlFJAAczd8uRb DFkjd6tHQjtv4YAayRI+yfwkkg== X-Google-Smtp-Source: ABdhPJwL++pJD4L+MhcL0A6SHv1i4wsCVEuiRGQywowtFewwQTqO0/sTBHuqb3SEkXQfuozSD66SpQ== X-Received: by 2002:a5d:4204:: with SMTP id n4mr1627187wrq.247.1591225740250; Wed, 03 Jun 2020 16:09:00 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id m129sm5182294wmf.2.2020.06.03.16.08.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2020 16:08:59 -0700 (PDT) In-Reply-To: <87lfl36abx.fsf@gmail.com> (Pip Cet's message of "Wed, 03 Jun 2020 22:41:54 +0000") Received-SPF: none client-ip=2a00:1450:4864:20::42a; envelope-from=contovob@tcd.ie; helo=mail-wr1-x42a.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251832 Archived-At: Pip Cet writes: > Jo=C3=A3o T=C3=A1vora writes: > >> (defun sly-make-action-button (label action &rest props) >> (apply #'sly--make-text-button >> label nil :type 'sly-action >> 'action action >> 'mouse-action action >> props) >> label) > > I think you want > (defun sly-make-action-button (label action &rest props) > (apply #'sly--make-text-button > label nil :type 'sly-action > 'action action > 'mouse-action action > props)) > > instead, since the new function returns a copy of label rather than the > string passed in. Note that doing that would break compatibility with Emacs < 24.3, which is when make-text-button started returning the modified string object, in case that's important to you. --=20 Basil