From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: Why are so many great packages not trying to get included in GNU Emacs? WAS: Re: Making Emacs more friendly to newcomers Date: Sat, 13 Jun 2020 22:24:57 +0100 Message-ID: <87wo4a64ly.fsf@tcd.ie> References: <87k12bdgx7.fsf@yahoo.com> <87r1wi7a8o.fsf@yahoo.com> <875zdteybt.fsf@runbox.com> <87368wrvf5.fsf@yahoo.com> <86k126d83n.wl-me@enzu.ru> <83pnbyckvv.fsf@gnu.org> <4923d7e98f5ed816a7569093dbc673153adcea88.camel@yandex.ru> <87tuzezrrl.fsf@tcd.ie> <7e47e9a4ccb739fbd0179d2b8ae3b7b48d19e316.camel@yandex.ru> <87h7ve7lox.fsf@tcd.ie> <22650dc349758df4b0c05269c407ecade6a24181.camel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="62373"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , Emacs developers , Stefan Kangas , Dmitry Gutov To: Konstantin Kharlamov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 13 23:26:19 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jkDfO-000G5j-4s for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Jun 2020 23:26:18 +0200 Original-Received: from localhost ([::1]:47502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkDfN-0007B0-7u for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Jun 2020 17:26:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkDeD-0006fc-Dc for emacs-devel@gnu.org; Sat, 13 Jun 2020 17:25:05 -0400 Original-Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:39819) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jkDe9-00083L-43 for emacs-devel@gnu.org; Sat, 13 Jun 2020 17:25:05 -0400 Original-Received: by mail-wm1-x342.google.com with SMTP id o8so1590540wmh.4 for ; Sat, 13 Jun 2020 14:25:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=3AxKJzGWSWbLZl7I1WxDuH2uIZv6/zO8cutC3YIMxJA=; b=luW+98Eo9o0taQ3/Gsm3hBLq7bzgZQjjrvTsZT/2kD52KJmg+RB+RrIhtc9o2VYpeG 0BnkFKxpJDhl7e+uxLDkYdU3cOekAzFF7lSuzhT+VELQ9IDAq+H632J40JxT+lecf8IY hm0FfrJGaCkrOAX4are7egxbbnvC4v658AOcsYrqwNDU0SLbsutgzi8pj8ecipKZmT3Q KHuXh6LrEYEZOxho1v3Xv7C7ONF/W93hGlR7rmUAHVQSgAFC58L7qNEYYx9Ny4132CES KXBvsMZqZ/r84Alx0YMbnuNPkiddDAgXFW3if8wShMj3NWiFC3lUQyGqqWWhVJ5ROnku e6tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=3AxKJzGWSWbLZl7I1WxDuH2uIZv6/zO8cutC3YIMxJA=; b=Obi0/9YsdiRtpV4Qw5sqse+WQCAJdgfus8YTkPc23O5mErUSCCG2NgaHf/PuEQOckg HlJ3bFSSdln2pbgAMFhbJOdihtyCHj2zVEKKv/Nnt49eiyaYoe2n6sWNWH08q4ua1MPn wJzWG5ncZiB2IkoJPA8UdXU2NtvneApjcVgWWLW0kI9PZ0oi/XvYmLUBsMRioLK91p00 8bf7FjSf2z7rAx3qcS/Q0i0tLTBBI9x/Mdnd0te+H9pIEk0JzFhHlOYediayYjS3KQDU tVZUnfcTboaIMeCCKA4oOTbLay22Kntq3HYp9MN6jW1xTKVK1kqm6xc7sqzXF+ewfkKu IhHw== X-Gm-Message-State: AOAM530aIQT0SviKxK1IBccFCdNJ/iUZJxC/kBbJh0SgZrsbdZdF19Rp 8MLYqQDGKjIOuJUaScVcvWrEdw== X-Google-Smtp-Source: ABdhPJxRpn20ypS/U/uKkEzuurNKRoIQLEj0febNIBxXf1bGCVzvMp5hg7isWBW33DbxVmiMkxeqyg== X-Received: by 2002:a7b:cbce:: with SMTP id n14mr5568737wmi.66.1592083499064; Sat, 13 Jun 2020 14:24:59 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id l17sm16664348wrq.17.2020.06.13.14.24.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Jun 2020 14:24:58 -0700 (PDT) In-Reply-To: <22650dc349758df4b0c05269c407ecade6a24181.camel@yandex.ru> (Konstantin Kharlamov's message of "Sat, 13 Jun 2020 23:52:56 +0300") Received-SPF: none client-ip=2a00:1450:4864:20::342; envelope-from=contovob@tcd.ie; helo=mail-wm1-x342.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252211 Archived-At: Konstantin Kharlamov writes: > On Sat, 2020-06-13 at 21:30 +0100, Basil L. Contovounesios wrote: >> Konstantin Kharlamov writes: >>=20 >> > You can get that purely with git by using option `-L` of gitlong. It h= as >> > syntax >> > `-L ::`. >> >=20 >> > To give you example, I just looked at my recent change in python.el, a= nd the >> > diff says the region belongs to `python-font-lock-keywords-maximum- >> > decoration`. >> > So I execute: >> >=20 >> > git log -L :python-font-lock-keywords-maximum- >> > decoration:lisp/progmodes/python.el >> >=20 >> > And I get a log of commits that changed that function. Git version 2.2= 7.0 >>=20 >> And what if a commit message references a particular variable or >> function without touching the file that they're defined in? I'm talking >> about more general xrefing. > > I feel there's some misunderstanding. The list our discussion is about on= ly > mentions changed functions/variables. If the git message references a var= iable > that is not changed just because it is important to mention, then, well, = it > should still be there, in the commit message. That's what good commit mes= sages > are for: you mention things that are important to mention =C2=AF\_(=E3=83= =84)_/=C2=AF Right, I was confused in my last reply. >> You didn't exactly. It is possible to take shortcuts depending on the >> context. See the file CONTRIBUTE or (info "(standards) Change Logs") >> https://www.gnu.org/prep/standards/html_node/Change-Logs.html. > > Oh, okay, so I read the docs, and apparently this "all callers are change= d" can > only be used when you use a calling convention. In my imaginary example w= here > you factored out a code from 34 functions it would not be a calling conve= ntion, > it would be a piece of code inside those functions. This is actually simi= lar to > the patch that replaces regexes to "xdigit": you have the same pattern *i= nside* > many functions that you replace. No calling convention changes. It doesn't strictly have to be a change in calling convention, you can use your better judgement. E.g. you can list only the affected files, and either way you only need to mention the same message once for all affected definitions. --=20 Basil