* Re: bug#38421: Status: 27.0.50; Gnus fontifies patch attachments when gnus-visual is nil
[not found] ` <m2lfrzu0ys.fsf@fastmail.fm>
@ 2019-12-17 12:55 ` Filipp Gunbin
2020-07-19 15:20 ` Lars Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Filipp Gunbin @ 2019-12-17 12:55 UTC (permalink / raw)
To: emacs-devel; +Cc: bug#38421
Could someone please review the patch? (bug#38421)
It's simple, but I'm not sure about using gnus-visual-p in mm-* files.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: bug#38421: Status: 27.0.50; Gnus fontifies patch attachments when gnus-visual is nil
2019-12-17 12:55 ` bug#38421: Status: 27.0.50; Gnus fontifies patch attachments when gnus-visual is nil Filipp Gunbin
@ 2020-07-19 15:20 ` Lars Ingebrigtsen
2020-08-02 17:45 ` Lars Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2020-07-19 15:20 UTC (permalink / raw)
To: emacs-devel; +Cc: bug#38421
Filipp Gunbin <fgunbin@fastmail.fm> writes:
> Could someone please review the patch? (bug#38421)
>
> It's simple, but I'm not sure about using gnus-visual-p in mm-* files.
I don't think we can use that function there, because these are general
utility functions (used by mh-e, for instance).
As the comment in mm-view.el says:
;; Shouldn't these functions check whether the user even wants to use
;; font-lock?
They should, indeed. But I'm not quite sure what the correct approach
for the application (that is Gnus) to inhibit these functions...
What functions to use is decided by mm-inline-media-tests, and there's
no way to use one version if we want highlights and another if we
don't...
Anybody got any ideas here?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: bug#38421: Status: 27.0.50; Gnus fontifies patch attachments when gnus-visual is nil
2020-07-19 15:20 ` Lars Ingebrigtsen
@ 2020-08-02 17:45 ` Lars Ingebrigtsen
0 siblings, 0 replies; 3+ messages in thread
From: Lars Ingebrigtsen @ 2020-08-02 17:45 UTC (permalink / raw)
To: emacs-devel; +Cc: bug#38421
Lars Ingebrigtsen <larsi@gnus.org> writes:
> What functions to use is decided by mm-inline-media-tests, and there's
> no way to use one version if we want highlights and another if we
> don't...
>
> Anybody got any ideas here?
Apparently not, so I added a variable callers (like Gnus) can bind to
switch font-locking off. Seems to work OK for me (in Emacs 28).
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-02 17:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <m2zhgfvmxf.fsf@fastmail.fm>
[not found] ` <m2lfrzu0ys.fsf@fastmail.fm>
2019-12-17 12:55 ` bug#38421: Status: 27.0.50; Gnus fontifies patch attachments when gnus-visual is nil Filipp Gunbin
2020-07-19 15:20 ` Lars Ingebrigtsen
2020-08-02 17:45 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).