unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: mattiase@acm.org, emacs-devel@gnu.org
Subject: Re: master a539488: Always make a multibyte string for the frame title (bug#42904)
Date: Sun, 23 Aug 2020 21:01:57 +0200	[thread overview]
Message-ID: <87wo1pdw4a.fsf@gnus.org> (raw)
In-Reply-To: <83tuwt6vmx.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 23 Aug 2020 21:54:14 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

> Silly compiler.  Please try again, I hope I fixed this.

Now the warnings are...  slightly different?  :-)

xdisp.c: In function ‘display_mode_element’:
xdisp.c:25643:36: warning: pointer targets in passing argument 1 of ‘multibyte_chars_in_text’ differ in signedness [-Wpointer-sign]
25643 |       if (multibyte_chars_in_text (spec, nbytes) != nbytes)
      |                                    ^~~~
      |                                    |
      |                                    const char *
In file included from xdisp.c:439:
lisp.h:3581:43: note: expected ‘const unsigned char *’ but argument is of type ‘const char *’
 3581 | extern ptrdiff_t multibyte_chars_in_text (const unsigned char *, ptrdiff_t);
      |                                           ^~~~~~~~~~~~~~~~~~~~~
xdisp.c: In function ‘decode_mode_spec_coding’:
xdisp.c:26264:62: warning: pointer targets in passing argument 2 of ‘CHAR_STRING’ differ in signedness [-Wpointer-sign]
26264 |  buf += CHAR_STRING (XFIXNAT (CODING_ATTR_MNEMONIC (attrs)), buf);
      |                                                              ^~~
      |                                                              |
      |                                                              char *
In file included from dispextern.h:25,
                 from composite.h:29,
                 from xdisp.c:441:
character.h:226:36: note: expected ‘unsigned char *’ but argument is of type ‘char *’
  226 | CHAR_STRING (int c, unsigned char *p)
      |                     ~~~~~~~~~~~~~~~^


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  parent reply	other threads:[~2020-08-23 19:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200823171831.19233.37353@vcs0.savannah.gnu.org>
     [not found] ` <20200823171832.86B3620A10@vcs0.savannah.gnu.org>
2020-08-23 18:41   ` master a539488: Always make a multibyte string for the frame title (bug#42904) Lars Ingebrigtsen
2020-08-23 18:54     ` Eli Zaretskii
2020-08-23 18:57       ` Mattias Engdegård
2020-08-23 19:01       ` Lars Ingebrigtsen [this message]
2020-08-23 19:11         ` Eli Zaretskii
2020-08-23 19:48           ` Lars Ingebrigtsen
2020-08-23 20:01             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wo1pdw4a.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).