From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 262d0c6: Mark some tests as expensive Date: Sun, 13 Sep 2020 19:22:58 +0200 Message-ID: <87wo0xr3pp.fsf@gmx.de> References: <20200910182904.20559.25935@vcs0.savannah.gnu.org> <20200910182905.F0E4520A2E@vcs0.savannah.gnu.org> <877dt0is0p.fsf@gmx.de> <83a6xve0vq.fsf@gnu.org> <87a6xv456t.fsf@gnus.org> <837dszdyqv.fsf@gnu.org> <877dsz2o03.fsf@gnus.org> <83363ndvql.fsf@gnu.org> <87zh5tzwog.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8879"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , mardani29@yahoo.es, stefan@marxist.se, Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 13 19:25:56 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHVlE-0002Dh-9N for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Sep 2020 19:25:56 +0200 Original-Received: from localhost ([::1]:32976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHVlD-0000eB-5X for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Sep 2020 13:25:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHViX-0007NP-JR for emacs-devel@gnu.org; Sun, 13 Sep 2020 13:23:09 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:42831) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHViV-0002Dl-K5; Sun, 13 Sep 2020 13:23:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1600017780; bh=O+bOq5QDUJLhiQypKz1PTi8HMRqJMRzV9vVQanOgjbU=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=ALKOcrwD5FOzot6vXbHvt3oAbKZTiajuVbU4hOhtLhqko0rI5zAmUoLxAiU9rvjMd R6zlALuH3o7pgNpscLQAkFfN2bOyUL0omUDXzxJwr/flzSOtsZ8+uSOO9dzu3Ln9B2 rk79DZtWfHyauRaZqEeFv/lz6HpuK7C4M69EzzsA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([217.70.140.194]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N6sit-1ka1et2cIR-018Lvn; Sun, 13 Sep 2020 19:23:00 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 13 Sep 2020 11:21:42 -0400") X-Provags-ID: V03:K1:XTW79g2PjTZN8WhLk5eM02OhP8/7K6viWcDrfvhJxTC00JJBxY6 O6lMUaVN9/uVxoShDmvnxcJz3AkRDxX5XLT8/oBRl2pX5k2Vj7tbFE+nSpI9XmR2uEZ0gjy BYZjFSn4mqfBLczgNhoOoUGSVi4eE9GsXazcktYqa2mZdG/OAt74H2IlPLB6tKH1UAqZb4n nZtyJv2ku63FCZKf9V8vQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:wSMtg2Ks9Us=:9cAeTYHiZrf0D2lSV6yCrg AKQ6Faj/ZD4Em0zSMwb2BK5HFgh4Z5a9ffYTht9jAiP/V/bodJId9k25L1O7rFs4KtUFt3aKk NVwSydET8gK6o6HpZYPqVwLs3JEPm8uOoRNTVsn54YTJthc9OH9KKZb0Q7zlvTk5SWASGQN+P +rhJI7MVaQi9u9rhcLFI76yvKSoXSyyWLTLspd8qUMrMlC5C5u3Rn5qfOsF/4sagQ0fqBR3rb Y8W29mLZpBr+wPRSRAqfQ4AWWp8PcnDfc1SjoVX0lJMlIi0VX2YY34z6Hw9zuQC0wLZo4XI7Y MLDWVyuaRHiQTfFy4U6GtuXQu5Jv6CjmsUIhDyXEDGxdQY3XdWsrOrsZjK0Ie/vIWgZJ0oyFR 1kZKG1vm/ajwG8HZR8FYPIQWbYZU+jgJ5cQlaDSzTkZAdevBPxVr2nwpgqZ7mI1Pct5p1q0/8 0xUfHOtRRYV7KvGk/1wm1r/9dAJ1KaEd1xXSIdoyFFXk1hzLmjQIt46J5W+LlxZpvtMQJZ79F AnmT6TV/emKASU2s3yDe7TRShXv+ebhzX14OC17qbdwb3mddo4QJmnlAOvpFkBPWa8xSTW8+c lIlknXG4kuAZGDDpcSzkK+vQ7ZhLYZcnc4kJ1hGNC+FI/grmfsKUStdzUrSUUZpunCxgl1Nr2 jZGN/zqK77UyfU+eLUAcEAcjWoTsxm9maj0eA+4L0c3WU/d0GUEwYGLMfIpqvR6laLTMoqATO I+frI4pNmAuVnzohdg79IGwJWOLLhQo1Beep6/LnyRrTttlOqxVcAJOtBs++2VTCVcFOuAJp Received-SPF: pass client-ip=212.227.17.22; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/13 13:23:05 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255533 Archived-At: Stefan Monnier writes: >> Having people do "make check" as a matter of routine, and running 97% of >> the tests is, in my opinion, better than people doing a "make check" >> seldom, but running 98% of the tests. >> >> Where the cutoff is a matter of balance, yes, but I think a test that >> takes a second is way too slow to be run in the routine case. > > FWIW, I think The Right Solution is to label each test with its "cost" > (which could be auto-computed by a script that runs those tests to > measure that cost). Then we can provide a command to run all tests > cheaper than X, and the end-user gets to decide where is "the cutoff" in > his balance. Nice idea. The problem will be to decide what are the default costs we accept running "make check". I fear that there will be voices to make the default costs such low, that (for example) auto-revert tests are kicked off. As we have now. > Stefan Best regards, Michael.