From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] tab-line-alternate-colors Date: Sun, 13 Dec 2020 23:25:21 +0200 Organization: LINKOV.NET Message-ID: <87wnxl760u.fsf@mail.linkov.net> References: <87360autpy.fsf@alphapapa.net> <87mtyiqfzv.fsf@mail.linkov.net> <87tusqt3yr.fsf@alphapapa.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32915"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Adam Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 13 22:46:36 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1koZCO-0008Ty-Bx for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Dec 2020 22:46:36 +0100 Original-Received: from localhost ([::1]:54022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koZCN-0007Wm-C3 for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Dec 2020 16:46:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koYu4-0007i6-9B for emacs-devel@gnu.org; Sun, 13 Dec 2020 16:27:43 -0500 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:52227) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koYu1-0001ER-Kb for emacs-devel@gnu.org; Sun, 13 Dec 2020 16:27:39 -0500 Original-Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 9674D200002; Sun, 13 Dec 2020 21:27:30 +0000 (UTC) In-Reply-To: <87tusqt3yr.fsf@alphapapa.net> (Adam Porter's message of "Sun, 13 Dec 2020 04:06:36 -0600") Received-SPF: pass client-ip=217.70.178.232; envelope-from=juri@linkov.net; helo=relay12.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260776 Archived-At: >> Thanks, it would be nice to support displaying tabs in alternating >> colors. But there are endless possibilities for look and feel of >> tabs, so instead of hard-coding only one of them for alternating >> colors, I suggest to add a customizable function with a name like >> 'tab-line-tab-face' that with a tab provided as its arg (and a list of >> tabs to be able to find the ordinal number of the given tab) would >> return its face to use. > > Yes, that seems like a good idea. Something like this? I also added > another face for non-file-backed buffers, which helps distinguish them. What if some users might want to display tabs with rainbow colors? Then this too specific option tab-line-alternate-colors won't help. What I suggest is that defcustom tab-line-tab-face-function could provide a separate function choice, e.g. tab-line-tab-face-alternate, so when customized to tab-line-tab-face-alternate, this function could call the default function tab-line-tab-face-default, and if the default function returns 'tab-line-tab-inactive', then replace it with 'tab-line-tab-inactive-alternate' depending on whether the tab is odd/even.