From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Add project-name function Date: Sat, 06 Mar 2021 15:10:28 +0100 Message-ID: <87wnuknzjf.fsf@posteo.net> References: <877dmltdwn.fsf@ya.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34811"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: emacs-devel@gnu.org To: Ivan Sokolov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 06 15:11:31 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIXeU-0008yh-Tr for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Mar 2021 15:11:30 +0100 Original-Received: from localhost ([::1]:49356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIXeU-0000nQ-0m for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Mar 2021 09:11:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIXdl-0008NB-HE for emacs-devel@gnu.org; Sat, 06 Mar 2021 09:10:45 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:42065) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIXdg-0003jo-6S for emacs-devel@gnu.org; Sat, 06 Mar 2021 09:10:45 -0500 Original-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id ED5D32400FD for ; Sat, 6 Mar 2021 15:10:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1615039837; bh=LwBTyGbPsXVsDEpNpuwbnBKjxL99FBdGMkA9rm6OUq0=; h=From:To:Cc:Subject:Date:From; b=b96ReEhRNBw3LJ8cN8T7QKvzRvuw4EYiVYLEqNRBex/WAPTobuNN/i1yVe+6H0Ks4 QoUlH2LMrp9oCdwHtPyfjzObc6aKc0RiNXzsQx9k4QWIca9ICQhIPntHTvlMbKA/bq 6N6MWVEOh3z0IBUjnAFY6t24ooa/AWYXEtuftQfUyQ6l2K0mC9uJN8fzS4aJ86xnqz 2t+m4ydxtX7h7heW7ZycvfI2IiP+6eXUflg7hDjA/D8Zez1Avq70V3VIB2mGEXRdMh smTYLjKFAoDyoZwTq82ldtLWxVaa71K9fOt3CKgJ8ioAwi9E9ZwULtG/MEAySc6qXJ TStLX1VxsyxoQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Dt62N2xw6z6tmJ; Sat, 6 Mar 2021 15:10:36 +0100 (CET) In-Reply-To: <877dmltdwn.fsf@ya.ru> (Ivan Sokolov's message of "Sat, 06 Mar 2021 01:48:56 +0300") Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266073 Archived-At: Ivan Sokolov writes: > I hope I am doing everything right, this is my first patch for Emacs. > > From 0aa1b0417f2fd4f8fdef24194c55304611711cfa Mon Sep 17 00:00:00 2001 > From: Ivan Sokolov > Date: Sat, 6 Mar 2021 01:43:30 +0300 > Subject: [PATCH] lisp/progmodes/project.el: Add 'project-name' > > --- > lisp/progmodes/project.el | 23 +++++++++++++---------- > 1 file changed, 13 insertions(+), 10 deletions(-) > > diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el > index abe563bec0..3abae8606f 100644 > --- a/lisp/progmodes/project.el > +++ b/lisp/progmodes/project.el > @@ -888,6 +888,13 @@ PREDICATE, HIST, and DEFAULT have the same meaning as in > (interactive) > (vc-dir (project-root (project-current t)))) > > +;;;###autoload > +(defun project-name (project) > + "Return PROJECT's name." Without reading the rest of the code, I wasn't sure what a project's name is. I think the docstring should explain that it just takes the basename of the root directory. It might be worth considering turning this into a method, in case a project knows a better name. > + (file-name-nondirectory > + (directory-file-name > + (project-root project)))) -- Philip K.