From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Some minor suggestions to Tab Bar Date: Thu, 25 Mar 2021 11:31:13 +0200 Organization: LINKOV.NET Message-ID: <87wntvd0zq.fsf@mail.linkov.net> References: <87mtustidk.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8981"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Gabriel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 25 10:58:47 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPMlL-0002EK-FJ for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Mar 2021 10:58:47 +0100 Original-Received: from localhost ([::1]:32902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPMlK-00048P-D4 for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Mar 2021 05:58:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40342) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPMju-000343-LD for emacs-devel@gnu.org; Thu, 25 Mar 2021 05:57:18 -0400 Original-Received: from relay13.mail.gandi.net ([217.70.178.233]:25557) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPMjs-0002EB-5G for emacs-devel@gnu.org; Thu, 25 Mar 2021 05:57:18 -0400 Original-Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay13.mail.gandi.net (Postfix) with ESMTPSA id D90CD8000F; Thu, 25 Mar 2021 09:57:11 +0000 (UTC) In-Reply-To: (Gabriel's message of "Wed, 24 Mar 2021 21:47:23 -0300") Received-SPF: pass client-ip=217.70.178.233; envelope-from=juri@linkov.net; helo=relay13.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267010 Archived-At: > I did some tests and works fine. I have found one edge case, > though. Imagine these tabs, consisting of [hint group name]: > > [1 g1 A] [2 g1 B] [3 g1 C] [4 g2 D] [5 g2 E] [6 g2 F] > > If we go to tab 2 and unset the group or set a new group (e.g.: "g3"), > the tab will not be moved, which will split the group "g1": > > [1 g1 A] [2 g3 B] [3 g1 C] [4 g2 D] [5 g2 E] [6 g2 F] > > I suspect that 'tab-bar-move-tab-to-group' fails to find another tab of > the same group to move to a closer position, so it leaves the current > tab where it is, without checking if this creates a misalignment. I have no idea where to move such dangling tab :)