From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 5) Date: Tue, 11 May 2021 20:59:35 +0300 Organization: LINKOV.NET Message-ID: <87wns5w3qw.fsf@mail.linkov.net> References: <0bbdeece-90d5-160c-07ec-2ad8edbf9872@daniel-mendler.de> <87czudm7bv.fsf@mail.linkov.net> <976056e8-3d46-db27-32c2-ddf3ca32d5a7@daniel-mendler.de> <878s5090e9.fsf@mail.linkov.net> <69fd42ed-a1a0-adcb-ac8b-caad80cb0967@daniel-mendler.de> <878s4zzpvc.fsf@mail.linkov.net> <95ac7ef3-5e8c-fc58-b316-544096c82aa0@daniel-mendler.de> <87o8dus00b.fsf@mail.linkov.net> <6718c89f-88a0-b529-1676-7e89fc152f00@daniel-mendler.de> <878s4w3law.fsf@mail.linkov.net> <87sg2ymq6j.fsf@mail.linkov.net> <78bb0663-80ef-a68f-c582-cd7cc0436c29@daniel-mendler.de> <069cec7d-db2c-8628-69fb-a2aee4ee5074@daniel-mendler.de> <6ac36d0f-bf5b-2124-1f70-69644bb40218@daniel-mendler.de> <871rafrdny.fsf@mail.linkov.net> <87pmxywc25.fsf@mail.linkov.net> <717189f4-cf65-8a07-fbcf-678242312530@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27034"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Gregory Heytings , "emacs-devel@gnu.org" , Stefan Monnier , Dmitry Gutov To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 11 20:32:39 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgXBP-0006wj-1k for ged-emacs-devel@m.gmane-mx.org; Tue, 11 May 2021 20:32:39 +0200 Original-Received: from localhost ([::1]:56834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgXBO-00048o-3b for ged-emacs-devel@m.gmane-mx.org; Tue, 11 May 2021 14:32:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgXAl-0002lj-Kn for emacs-devel@gnu.org; Tue, 11 May 2021 14:31:59 -0400 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:47969) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgXAj-0007tp-JN for emacs-devel@gnu.org; Tue, 11 May 2021 14:31:59 -0400 Original-Received: from mail.gandi.net (m91-129-102-166.cust.tele2.ee [91.129.102.166]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 798D4200005; Tue, 11 May 2021 18:31:52 +0000 (UTC) In-Reply-To: <717189f4-cf65-8a07-fbcf-678242312530@daniel-mendler.de> (Daniel Mendler's message of "Tue, 11 May 2021 09:51:45 +0200") Received-SPF: pass client-ip=217.70.178.232; envelope-from=juri@linkov.net; helo=relay12.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269171 Archived-At: > 1. By doing such an override the ability of the user to configure the > completion UI is subverted. Such an override could be advisable only when the API user provides an equivalent user option with more choices when necessary. > 2. Since the variables are let-bound, they influence the behavior of > nested recursive completion sessions. It is better to override the > variables with `setq-local` in a `minibuffer-setup-hook`. Agreed. > +(defcustom completions-group-sort-function #'identity > + "Sorting function for the groups. > +The function takes and returns an alist of groups, where the each > +element is a pair of a group title string and the candidate strings > +belonging to the group." > + :type 'function > + :version "28.1") As the most useful non-default choice, it could also include a function to sort alphabetically.