From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sergey Organov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: Should (buffer-list) ever return killed buffers? Date: Mon, 24 May 2021 18:32:18 +0300 Message-ID: <87wnroxi4d.fsf@osv.gnss.ru> References: <87wnrpujo0.fsf@osv.gnss.ru> <871r9w5jws.fsf_-_@osv.gnss.ru> <83a6okdx60.fsf@gnu.org> <6381ce45-24d5-90f7-c490-7006460f7f43@gmx.at> <835yz8dvfk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33060"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: martin rudalics , cpitclaudel@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 24 17:34:48 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llCbN-0008Ko-OV for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 17:34:45 +0200 Original-Received: from localhost ([::1]:37762 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llCbM-0006Kz-Rl for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 11:34:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llCZA-0002g6-Fm for emacs-devel@gnu.org; Mon, 24 May 2021 11:32:28 -0400 Original-Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]:46773) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llCZ5-0003Vn-7s; Mon, 24 May 2021 11:32:24 -0400 Original-Received: by mail-lj1-x234.google.com with SMTP id e11so34089762ljn.13; Mon, 24 May 2021 08:32:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=y5Q6YhqIdF6sqpu6kq4C01dfxEtix0y0z7gnL7ZEAJ4=; b=kGUzBoo7rcjI8BRnS2b3wzQa+XkCMQg7b5ZmvFTGrelzEYL/zt3+Kk6j7Nl7ajkvr2 Y806hqNWezntDfynpWyD032BEE4u2o1v3NrHqhwlTxXgDE44/ywV5kBOWyZxGzIl0SKU ROZnZB6yhto3L/m2Xk7ZFRVxOo93RXtOUdtRW4O5GSrIYNVBnW9FHuFdeGg0jCFBHyGO hROqOmxJD3Guq5qm2/5EV9uPvmZcG9VA68nUuMYsByiqsbLLdESsPdsXrGQOOqzgx914 b26pQ2/ksRM1BRr/O/XbXjlf1y+q2LtKqnuWROmSZ0yTxtJ6Navlyq1SX2xmaoqRE2Nj modA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=y5Q6YhqIdF6sqpu6kq4C01dfxEtix0y0z7gnL7ZEAJ4=; b=UVoP5DwV6MRog4MJJMb30wCGmp+D+ASeH5nB3pH4D+iieiZ+B2g6YVOJFE/JvrWLy0 z7L2+UXzrcBKs2ZuS+kwo/JmnB30jjmTVyd+y6+Eq9qAzVmicRpptvA6vZq4OHgILeit bJDMnWJmNua+U2u8qtZWs1be2cDo/HAzAuXC6hO4G4At1fzT/hMHykyOZS8SIlhT0sSG p/LSediOwzqzL7r0AKA87pq9RN1U2lQzQ2vINzQRfvE1pTfH+7lyUo9ATRiXcoHZKXU+ HgtnWXj9SOzbEyhdhUvswRE1mD50m+hy/RXgrAzl1t/mLRuSwveVO7aifKKTPnkz/zTx m8Sg== X-Gm-Message-State: AOAM530vsJ8GlPFJYE5b+wuk1un9RhDOhB9mzghiRpwFZ9+eH0c/eR3H 3LNmRR4oWm4eKsN7dsCkMRuUBTuiuRQ= X-Google-Smtp-Source: ABdhPJx/BTl+60ohIIAfx6ZVsAL+nL5CZHeG4mKqgtRdx/tJDMCFwFlnrOSR6uAwK5ZiBabf8ytwTg== X-Received: by 2002:a2e:9e53:: with SMTP id g19mr18139424ljk.58.1621870339811; Mon, 24 May 2021 08:32:19 -0700 (PDT) Original-Received: from osv.localdomain ([89.175.180.246]) by smtp.gmail.com with ESMTPSA id h16sm1450544lfj.194.2021.05.24.08.32.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 May 2021 08:32:19 -0700 (PDT) In-Reply-To: <835yz8dvfk.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 24 May 2021 18:05:03 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::234; envelope-from=sorganov@gmail.com; helo=mail-lj1-x234.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269766 Archived-At: Eli Zaretskii writes: >> Cc: cpitclaudel@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org >> From: martin rudalics >> Date: Mon, 24 May 2021 16:50:48 +0200 >> >> >> + (unless (or (nill bufname) >> >> + (eq (aref bufname 0) ?\s) ;; Don't kill internal buffers >> >> (string-match-p preserve-regexp bufname)) >> >> (kill-buffer buffer))))) >> >> (delete-other-windows) >> > >> > AFAICT, kill-buffer already is a no-op when the buffer is dead. So >> > what exactly does this fix? (Apologies if I'm missing something: I >> > cannot say that I've read all the discussions in this thread to the >> > last detail.) >> >> Sergey never told us but it's likely `aref' choking on nil. > > Then why not use buffer-live-p? Cause aref is choking on bufname being nil, I think. What if representation of killed buffers change? Thanks, -- Sergey