From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: [External] : Re: [PATCH] When deleting in bookmark menu, prompt for confirmation. Date: Tue, 25 May 2021 00:38:22 -0500 Message-ID: <87wnrn4bld.fsf@red-bean.com> References: <87a6pcqy7s.fsf@red-bean.com> <83czu86o46.fsf@gnu.org> <835z006jpl.fsf@gnu.org> <87im3z3f8f.fsf@red-bean.com> <83zgxb67g2.fsf@gnu.org> <87mtt9sqh4.fsf@red-bean.com> <87czu58uso.fsf@gnus.org> <878s4tq8e6.fsf@red-bean.com> <874kfguail.fsf@red-bean.com> <875yzwtkuj.fsf@gmail.com> <87lf8prm2f.fsf@gmail.com> <83eeeg8ez9.fsf@gnu.org> <87h7jboirj.fsf@red-bean.com> <83cztz7nvd.fsf@gnu.org> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18220"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: larsi@gnus.org, orontee@gmail.com, monnier@iro.umontreal.ca, drew.adams@oracle.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 25 07:40:06 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llPnS-0004YM-7c for ged-emacs-devel@m.gmane-mx.org; Tue, 25 May 2021 07:40:06 +0200 Original-Received: from localhost ([::1]:51320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llPnQ-0005Z9-NC for ged-emacs-devel@m.gmane-mx.org; Tue, 25 May 2021 01:40:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48086) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llPm2-0004qk-8N for emacs-devel@gnu.org; Tue, 25 May 2021 01:38:38 -0400 Original-Received: from sanpietro.red-bean.com ([45.79.25.59]:58830) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llPlz-0002aJ-2R; Tue, 25 May 2021 01:38:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:Reply-To:References:Subject:Cc:To:From:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hTYQ1D9VWU4t4iaWCGZqVR7yM8oCM/1+ukJLkjkxYlY=; t=1621921112; x=1623130712; b=hldawalLWf/ARJCR3rNyM2L+JGHS1HTvcPNEYTli+mYgoo+Ot4adE7DH8nkQyKi13ST45SX6Ig 1P8oMTdtgbGHZnY3zOV2jbpN2YauAbbBFng6sse7mLmT7B/NeTfIbJZhYZUgxQFF8c0qCT/FrwcxC ixDxwXKGhgasF5SH07gHtrxj2zb8AGEpCsSuwYc9Z+P4Zos4Gkt3tjUZ7rzSjiqzz1n86O2jzO3rp IJEwDuvvOKfUc+Egec4y+6t8hhl7Y4lhCHZETVlLLaXB57paPVx83gbtm868f6zO6hRrtN7MJUFe+ FRyxV2RNDu5lty2KhnhoMySlNbeXdg96uj1QQ==; Original-Received: from 99-112-125-163.lightspeed.cicril.sbcglobal.net ([99.112.125.163]:43368 helo=floss) by sanpietro.red-bean.com with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llPln-00075G-HB; Tue, 25 May 2021 05:38:23 +0000 In-Reply-To: <83cztz7nvd.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 09 May 2021 21:39:34 +0300") Received-SPF: pass client-ip=45.79.25.59; envelope-from=kfogel@red-bean.com; helo=sanpietro.red-bean.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269834 Archived-At: --=-=-= Content-Type: text/plain; format=flowed On 09 May 2021, Eli Zaretskii wrote: >> From: Karl Fogel >> Cc: Matthias Meulien , >> drew.adams@oracle.com, >> larsi@gnus.org, monnier@iro.umontreal.ca, >> emacs-devel@gnu.org >> Date: Sun, 09 May 2021 13:37:52 -0500 >> >> My inclination would be to do this by having >> `bookmark-bmenu-load' >> just refer readers to `bookmark-load', and then improving the >> latter's doc string. That way if future changes are made to >> `bookmark-load's behavior, we wouldn't need to remember to >> update >> `bookmark-bmenu-load's doc string too. >> >> Thoughts? > >I'll have thoughts when I see the result ;-) Heh, fair enough. My inquiry was about the general practice of having one function's doc string referring out to another function's. But it sounds like you have no objection to that, and neither do I. If the attached doc patch looks sensible, I'll commit it. Best regards, -Karl --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=0001-Improve-bookmark-bmenu-load-doc-string.patch >From e0dac0712bf2ee9cef1ab067dbc26c6a00a1f85b Mon Sep 17 00:00:00 2001 From: Karl Fogel Date: Tue, 25 May 2021 00:26:57 -0500 Subject: [PATCH] Improve `bookmark-bmenu-load' doc string * lisp/bookmark.el (bookmark-bmenu-load): Refer reader to `bookmark-load' for more information. As discussed in this thread: https://lists.gnu.org/archive/html/emacs-devel/2021-05/msg00389.html From: Karl Fogel To: Eli Zaretskii Cc: Matthias Meulien, Drew Adams, Lars Ingebrigtsen, Stefan Monnier, Emacs Devel Subject: Re: [External] : Re: [PATCH] When deleting in bookmark menu, prompt for confirmation. Date: Sun, 09 May 2021 13:37:52 -0500 Message-ID: <87h7jboirj.fsf@red-bean.com> --- lisp/bookmark.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git lisp/bookmark.el lisp/bookmark.el index 64b467adfa..e6a22f9bf0 100644 --- lisp/bookmark.el +++ lisp/bookmark.el @@ -2063,7 +2063,9 @@ bookmark-bmenu-save (defun bookmark-bmenu-load () - "Load the bookmark file and rebuild the bookmark menu-buffer." + "Load the bookmark file and rebuild the bookmark menu-buffer. +This invokes `bookmark-load' interactively, so see there for more +information (such as how a prefix argument is handled)." (interactive nil bookmark-bmenu-mode) (bookmark-bmenu-ensure-position) (save-excursion -- 2.30.2 --=-=-=--