From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: Cleaning up rcirc Date: Fri, 11 Jun 2021 13:10:55 +0200 Message-ID: <87wnr08xj0.fsf@gnu.org> References: <874kedu0cm.fsf@posteo.net> <877dj94liu.fsf@igel.home> <87im2tlcwy.fsf@posteo.net> <87sg1urfwu.fsf@gnu.org> <87sg1pwwfd.fsf@posteo.net> <87zgvx34s4.fsf@gnu.org> <87sg1pidwy.fsf@posteo.net> <87a6nx9ecz.fsf@gnu.org> <877dj0aoop.fsf@gnu.org> <87k0n0ixag.fsf@posteo.net> <874ke4agi9.fsf@gnu.org> <87im2kwx9z.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10741"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.5.13; emacs 28.0.50 Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 11 13:15:59 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lrf8o-0002aj-UE for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Jun 2021 13:15:58 +0200 Original-Received: from localhost ([::1]:52754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrf8n-00057T-O2 for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Jun 2021 07:15:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrf6O-0001GN-IZ for emacs-devel@gnu.org; Fri, 11 Jun 2021 07:13:28 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43078) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrf6O-00072n-33; Fri, 11 Jun 2021 07:13:28 -0400 Original-Received: from auth1-smtp.messagingengine.com ([66.111.4.227]:50723) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrf6N-00062p-Uq; Fri, 11 Jun 2021 07:13:28 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailauth.nyi.internal (Postfix) with ESMTP id 660AF27C0054; Fri, 11 Jun 2021 07:13:27 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 11 Jun 2021 07:13:27 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedujedgfeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvufffkfgjgggtsehttdertddtredtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnhepie dtteetgeffhfehvdehuddvjefhgfehtddvtdduudevheegffdvieelhffgleevnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomh gvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdel kedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 11 Jun 2021 07:13:26 -0400 (EDT) In-reply-to: <87im2kwx9z.fsf@posteo.net> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270697 Archived-At: Hi Philip, >> No, not really. `rcirc-update-activity-string' just updates >> `rcirc-activity-string'. Maybe that should call >> >> (force-mode-line-update t) >> >> at least if the new and old activity string aren't equal? > > I cannot reproduce the issue (at least in my GUI instance, I'll take a > look at TUI). Can you observe it making a difference? Yes, with this patch it works for me on my TUI instance. (I'm not sure if that's the right thing to do, though.) --8<---------------cut here---------------start------------->8--- modified lisp/net/rcirc.el @@ -2154,7 +2154,8 @@ rcirc-next-active-buffer (concat " Type C-u " (key-description (this-command-keys)) " for low priority activity.") - ""))))) + ""))) + (rcirc-update-activity-string))) (define-obsolete-variable-alias 'rcirc-activity-hooks 'rcirc-activity-functions "24.3") @@ -2229,7 +2230,8 @@ rcirc-update-activity-string ((not (null (rcirc-process-list))) "[]") (t "[]"))) - (run-hooks 'rcirc-update-activity-string-hook))) + (run-hooks 'rcirc-update-activity-string-hook) + (force-mode-line-update t))) (defun rcirc-activity-string (buffers) "Generate activity string for all BUFFERS." --8<---------------cut here---------------end--------------->8--- Bye, Tassilo