From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master f3aa648: Make `lookup-key' understand the new key sequence syntax Date: Tue, 19 Oct 2021 15:40:57 +0200 Message-ID: <87wnm9dtee.fsf@gnus.org> References: <20211019030801.23534.79581@vcs0.savannah.gnu.org> <20211019030802.83DE621120@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10825"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 19 15:42:03 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcpNS-0002bL-6e for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Oct 2021 15:42:02 +0200 Original-Received: from localhost ([::1]:38716 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcpNQ-0003Iy-BL for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Oct 2021 09:42:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcpMX-0002cL-7y for emacs-devel@gnu.org; Tue, 19 Oct 2021 09:41:05 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:53106) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcpMU-0002TZ-Nl for emacs-devel@gnu.org; Tue, 19 Oct 2021 09:41:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aowKffXQFrCwj3QVN3mVLBICQnW64exLOwjygLXKolA=; b=riu8HoLFaMoaI9FvGkDCzqtj/Z 2FcYw+Yo8F6gS/hm1DVMwoP09SDY+mSkhhrZefAEZQ05ZG7x8PAhEjfCz6BkL5UR8MljFoxhJDZMz zNOb2TPcVShkIpSh9zq3Dy0IJEzO8553XVruAbPMmva+PdcX11Nkrz7j2w/reAvXCl7I=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcpMP-0006OQ-P8; Tue, 19 Oct 2021 15:41:00 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEUiFxxzjJeWqbBi d4xKTVe0v8fR09r///86u1foAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+UKEw0SLi67Lg4AAAGjSURB VDjLnZNRkoMgDIaZlgsoewHTpc+rOPtslQvITLgB3P8Im0RQ2/FpU6fM5DN//gAqRdG6cYGujTln xEgPLUqAcQ5MTyAm5IdWAdC5vnEDpShS5n+p0CGY3jgQkSR6G7jFwCUWKZcT6yACg9/8RGgABFAf qgABmzaA3dIJAwi455TYJLIhfge6RsBMNjcrSTA0HAWQBINNktJmJPB6ihvKsSbpN854v4MsQ3AB gUkXIGJYDHWiw8CWARhCoP2ZdhB3gO8Aa01iU0VJDWfApn4qAIv2aNKZoqR6sGDjrtVVJfUC3tiU CoGqpBYGtH+lJkwnwO0LSGsFfg4Mahf8VjsgXQylIoVpr1hyBm6Dcn0e+gA2Bj5MayOGdfQV6GXI fESWf2H92k0p38aygdRnPfJKb9dDzjWM6hQzxCQFtOVv4A4g+w0tjNMZ6LmzNAsd6u6orPrRA5jD KBmqq8RZpCye0XQBJmJv4PSKW/wluPEM7qJIy0fxuCBDoDvbfgC+wjS+8Z9t5G7PYJrxyoAeqP2l ZSLN+JHbXtS9uZ5l6/Xv+AMd4re+5ctE/AAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMS0xMC0xOVQx MzoxODo0NiswMDowMDEI1aUAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMTAtMTlUMTM6MTg6NDYr MDA6MDBAVW0ZAAAAAElFTkSuQmCC X-Now-Playing: Rocket To The Sky's _Medea_: "Grizzly Man" In-Reply-To: (Stefan Monnier's message of "Tue, 19 Oct 2021 08:45:37 -0400") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277359 Archived-At: Stefan Monnier writes: > I think your `possibly_translate_key_sequence` should be extended to > cover the XEmacs format as well, And it should be exported to ELisp. lookup-key/define-key already understands that format, but mixes the interpretation into the code itself. (lookup-key (current-global-map) [(control x) (control f)]) => find-file Pulling it out of the code and putting it into possibly_translate_key_sequence would be fine, I think. > And I'd argue it should also convert strings to vectors. Sure. > Oh and also convert [M-C-next] to [C-M-next]. Uhm... I'm not sure what the impact would be... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no