From: Po Lu <luangruo@yahoo.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: atamariya@gmail.com, emacs-devel@gnu.org
Subject: Re: SVG widget in GNU Emacs
Date: Wed, 20 Oct 2021 21:17:29 +0800 [thread overview]
Message-ID: <87wnm7al92.fsf@yahoo.com> (raw)
In-Reply-To: <83a6j3c092.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 20 Oct 2021 16:08:09 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> Here's an example:
>
> static int
> scrolling_window (struct window *w, int tab_line_p)
> {
> ...
> #ifdef HAVE_XWIDGETS
> /* Currently this seems needed to detect xwidget movement reliably.
> This is most probably because an xwidget glyph is represented in
> struct glyph's 'union u' by a pointer to a struct, which takes 8
> bytes in 64-bit builds, and thus the comparison of u.val values
> done by GLYPH_EQUAL_P doesn't work reliably, since it assumes the
> size of the union is 4 bytes. FIXME. */
> return 0;
> #endif
> This disables one of the more important display optimizations in an
> Emacs compiled with xwidgets support.
Thanks. Since I can't work on this right now, I'd like to ask if
changing the field `val' from `unsigned' to `void *' would work to
resolve this particular issue.
> Apart of the above, just look at xwidget.c and xwidget.el, and you
> will see the FIXMEs, the incomplete doc strings, and other stuff left
> unfinished. The idea was that those will get finished once the
> feature is in the sources, but unfortunately it didn't happen.
Indeed, I see your point. Thanks.
I will probably work on this once I get the time.
next prev parent reply other threads:[~2021-10-20 13:17 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 2:00 SVG widget in GNU Emacs Anand Tamariya
2021-10-20 3:15 ` Po Lu
2021-10-20 12:09 ` Eli Zaretskii
2021-10-20 12:48 ` Po Lu
2021-10-20 13:08 ` Eli Zaretskii
2021-10-20 13:17 ` Po Lu [this message]
2021-10-20 14:13 ` Eli Zaretskii
2021-10-26 6:32 ` Akira Kyle
2021-10-26 12:32 ` GUI and redisplay work (was: SVG widget in GNU Emacs) Stefan Monnier
2021-10-26 12:51 ` Stefan Kangas
2021-10-26 13:23 ` Eli Zaretskii
2021-10-26 13:19 ` Eli Zaretskii
2021-10-27 16:07 ` Alexandre Garreau
2021-10-27 17:12 ` tomas
2021-10-27 19:00 ` Alexandre Garreau
2021-10-29 17:34 ` GUI and redisplay work Arthur Miller
2021-10-29 19:29 ` Alexandre Garreau
2021-10-29 20:05 ` Alexandre Garreau
2021-10-27 9:47 ` SVG widget in GNU Emacs Po Lu
2021-10-27 12:10 ` Eli Zaretskii
2021-10-27 12:25 ` Po Lu
2021-10-27 20:01 ` Akira Kyle
2021-10-28 1:21 ` Po Lu
2021-10-28 13:50 ` Fix flickering on X11 xwidgets (was: Re: SVG widget in GNU Emacs) Po Lu
2021-10-27 19:49 ` SVG widget in GNU Emacs Akira Kyle
2021-10-28 1:15 ` Po Lu
2021-10-28 6:15 ` Eli Zaretskii
2021-10-28 9:39 ` Po Lu
2021-10-20 22:35 ` Richard Stallman
2021-10-20 23:37 ` dalanicolai
2021-10-21 0:31 ` dalanicolai
2021-10-21 0:07 ` Po Lu
2021-10-20 8:15 ` Lars Ingebrigtsen
2021-10-20 9:13 ` Anand Tamariya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnm7al92.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=atamariya@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).