From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: GStreamer xwidget Date: Fri, 19 Nov 2021 13:49:06 +0800 Message-ID: <87wnl4ofu5.fsf@yahoo.com> References: <87ee7cq2mu.fsf.ref@yahoo.com> <87ee7cq2mu.fsf@yahoo.com> <87lf1kyaae.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10002"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 19 06:50:38 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnwnF-0002O0-No for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Nov 2021 06:50:37 +0100 Original-Received: from localhost ([::1]:37164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnwnE-0007FL-7k for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Nov 2021 00:50:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnwm1-0005qN-B5 for emacs-devel@gnu.org; Fri, 19 Nov 2021 00:49:21 -0500 Original-Received: from sonic306-20.consmr.mail.ne1.yahoo.com ([66.163.189.82]:35486) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mnwly-0000Xu-Aj for emacs-devel@gnu.org; Fri, 19 Nov 2021 00:49:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1637300956; bh=0cxxzItrDRjjAnjWE7OxEVYnEiEXIufHr7e200ZPUrg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=Isrc2V03r8rKfa8b+IyH8N8+UM6TEUyNJy5G/1sxHZA4Vrb4Yr0reC2l43gbT081PXxP4l/BXbttBItszgOTuc+GLgQ6u6b1A42aW0Z8aVGn+1ipBrUQ8h9LJ4d1nYdEwU5W01DOEIpVaun9PIgyHknPALzBVwsrF/Nng6aeyK6pCVBSIdQS1dG9a1I702RfNhWYmHCf8e7NG5H/eaN86HJ59/Uc1OWKdUSZXQMD3Zq0pRGQ5b0bu1cTf9VXRMEhe8IMhAXdBWY/ObSyxYCK0wJJOy1zk/IoPZJQJ1Qa+h6XFIEzec0mccTJJ1vVKK/DGMMyLRGWYs2Y/oZpuugXcg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1637300956; bh=aSjE1GM5KqVS2B9ZM4LKIl8Z782jIQtdzxwkLbeCVCc=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=AxiIlt3+65kkYp6vWtGjPiE407iBqsE/2goNOUJEzE0u8BvlibWBInjloNgcEyuXUYbGd/ppCYdYJJANbDa2QPhLgOAH15ofeIaD47GsudZ2HYb5kKtS1N7HMnJTVQ/p3dXzoEHTI3E+Kb6mPq+PV3bWWeDT4f+TTb6ajgUIwam9BGQvvLpDcjudCTpk3XcjQ3AW1vXB6g2PhS6Q4Jt6x1VKUfA+XFNpPac44vz7z4h5VfCFUTObE18ImFdeDuwVZKigw3PYfGGR8PdKf0PHgrbRfnnQf2wmnbwWVc/95LpabTDGjXzAlj1TVa4n6M0aYdbg5tqW2T13nQjK2Jr2kQ== X-YMail-OSG: AXKlSDwVM1lfgtRzl7YF6ll0kZ0PKP_Vz49Cmt6k1eBl_qGfDagg3QxpTzHiMM_ gL3yQL3pD4nHXSpqAZCLX4DTg2aeqY5K2RYx5.JKWLmgxYt9kY9TWDOF1y028q_4wHOzMioDlWuI UUOwhnTFDqt9TKF5wYVimh80QwGBQvCOOawjCF53P3TniR6HhdD4pqbH6L_UIfzm_g0KisuMWz_P iydi31POqSQJpHzfcqPnlTq6LcY8TBRLL1PQ5ZGsXS0RoTjyA3ssmDjw3X0jGIugDqOCoxaUT1Pq iEjz5CGmHY4kBSogHMCYXmYPYyhhTpXcnYIaHBfynJJ1o_4_J2mcbiEG5hFjs2HfPFraQS3ae0gB QJHlzncKy1VBRywFx43EgMW1jU3ncxYcnTUpml5A0q.GU8yDbXcFJSloiEqE5UZ2j77E8RNRXTX6 M0NYnQvhFVm9FJ1aglAJAT9c1lx8sIMt0YCfMbaaJGLHlB1fVL_Z52Ij8D6OubiRwubB.IKUH930 O1Gvo36mErQxVyKTncK6gBUy._qq2uSxEqLALCSZ1F6I58zSK5HGg91hopHqSrlpfSV_w6ytgGBf P.Y8mMdNmlsFM8zTPlidoZQMqmuyysGGcy9kztmQDlWimF2GsdvHqxYMNxKrwuf6BnZqCBJ63Swx lY8bGCWiAfxD62yFb88bviGK04pxntxUgt6uGb59hmuB_g6y1osknUSOtNbYlc7nudbKWtzzNWXo dLjaOt0cecWPZoxMa3U1hOkGzMxiJBaEIlneNd1r2CmDgV3cyNNs1oGOkU2qz7aYad6h1OFthUVe AsZHBAuBfZcR3yYrO_zuwUhfe.JtGUoqFl3duwjY0I X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Fri, 19 Nov 2021 05:49:16 +0000 Original-Received: by kubenode517.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID dc2b07cf32b5b9bf4725a26c274acb45; Fri, 19 Nov 2021 05:49:10 +0000 (UTC) In-Reply-To: <87lf1kyaae.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 19 Nov 2021 06:38:49 +0100") X-Mailer: WebService/1.1.19306 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.189.82; envelope-from=luangruo@yahoo.com; helo=sonic306-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279710 Archived-At: Lars Ingebrigtsen writes: > Hm... isn't the webkit rendering done offscreen? And that's able to > play videos just fine? Not on macOS, which is presumably where you tested the video playback, where a single xwidget can be displayed by only one Emacs window at a time. On GNU systems, the offscreen rendering causes some video playback to consume large amounts of CPU (as it can't utilize hardware acceleration for video decoding). And the more immediate problem this tries to solve is video playback not working at all in most newer versions of WebKitGTK. > Sounds good to me. > > Do you have a code snippet that will display one of these widgets? Then > I can test the patch here. Try this: (require 'xwidget) (setq xw (make-xwidget 'media "foo" 100 100)) (insert (propertize "foo" 'display (list 'xwidget :xwidget xw))) (xwidget-media-play xw) > Skimming the patch, it looks good to me. The one extremely minor nit I > have is this superfluous {}: >> +#ifdef HAVE_GSTREAMER >> + if (EQ (xw->type, Qmedia)) >> + { >> + XResizeWindow (xv->dpy, xv->internal_window, >> + xw->width, xw->height); >> + } It would be ugly to wrap the arguments to call there, and still rely on implicit braces. IMO. But if that's really a problem, I can remove it. Thanks.