Re: GStreamer xwidget

[Po Lu <luangruo@yahoo.com>]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Hm...  isn't the webkit rendering done offscreen?  And that's able to
> play videos just fine?

Not on macOS, which is presumably where you tested the video playback,
where a single xwidget can be displayed by only one Emacs window at a
time.  On GNU systems, the offscreen rendering causes some video
playback to consume large amounts of CPU (as it can't utilize hardware
acceleration for video decoding).

And the more immediate problem this tries to solve is video playback not
working at all in most newer versions of WebKitGTK.

> Sounds good to me.
>
> Do you have a code snippet that will display one of these widgets?  Then
> I can test the patch here.

Try this:

  (require 'xwidget)

  (setq xw (make-xwidget 'media "foo" 100 100))
  (insert (propertize "foo" 'display (list 'xwidget :xwidget xw)))
  (xwidget-media-play xw)

> Skimming the patch, it looks good to me.  The one extremely minor nit I
> have is this superfluous {}:

>> +#ifdef HAVE_GSTREAMER
>> +	      if (EQ (xw->type, Qmedia))
>> +		{
>> +		  XResizeWindow (xv->dpy, xv->internal_window,
>> +				 xw->width, xw->height);
>> +		}

It would be ugly to wrap the arguments to call there, and still rely on
implicit braces.  IMO.

But if that's really a problem, I can remove it.

Thanks.