From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master e37eb7f: Add support for pixel wheel deltas on NS Date: Thu, 25 Nov 2021 11:47:00 +0100 Message-ID: <87wnkwfr6j.fsf@gmail.com> References: <20211125030922.2353.1129@vcs0.savannah.gnu.org> <20211125030924.7258E2094B@vcs0.savannah.gnu.org> <871r34h6pi.fsf@gmail.com> <87fsrkzfq1.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25133"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 25 11:48:50 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqCJ8-0006PA-1I for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Nov 2021 11:48:50 +0100 Original-Received: from localhost ([::1]:56994 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqCJ6-0002qm-0h for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Nov 2021 05:48:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqCHR-0000e8-VW for emacs-devel@gnu.org; Thu, 25 Nov 2021 05:47:05 -0500 Original-Received: from [2a00:1450:4864:20::431] (port=43745 helo=mail-wr1-x431.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mqCHP-0001pJ-Mm for emacs-devel@gnu.org; Thu, 25 Nov 2021 05:47:05 -0500 Original-Received: by mail-wr1-x431.google.com with SMTP id v11so10610779wrw.10 for ; Thu, 25 Nov 2021 02:47:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=KSeXaw2VCF4uiKW3W/vwk220Jnx5t3ZZtEdAjxmYWiw=; b=pfmNouFqLrFbAK0DzEE4SlbNL6D+zPbIte2IEfserJyIFqSBQLqbnMeGrF0Y+D5pEd Dum9kSvZ/Tn1dSbj7fKGAobhL6dHhf30fC6WPpl8K2vmzr1vs2LYl3yUURv8GAn5pnFj XGxQoH9KSNKDLO9EcGktaUk/dVTVv//TMVQRy6UUYGLatH8LWnTRAigMK/RY2IWrdnBo 9uXE02cjRsZyjZuCndq9c6erbn0tlofymfH0HRH5JFZYx7Vxy0TTlD7ryR2yFI1Vae7Z l9ettOLm3FAeydZ8iQIpJuEprwXydGt1kjq/12xcI0gi9UihrH+H4wS/0z6DkVbiIVGA 4zzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=KSeXaw2VCF4uiKW3W/vwk220Jnx5t3ZZtEdAjxmYWiw=; b=GBfldZZeK5j3DC4Ld+Y4Fak/emzXtW+SNJOpoRHjXtbfp8Kf+o3RBK5xiF6UPV2A7X qLntwIJ8afzXG3gLE6B/MZ7Yvud5b3wnL9GGAlwlJqOToGnk1T9UaWyPfSYWtDeNMxUt qeg+xzZ/hYD3mpfdHd3tdXDtfF53Jaf0GmUK1eDuk7UgoNUUSliC+galRFZZqBA70Xya QNyQq7LC5PWqn9qbrzBkXSfCX4xEt4Vy/yK0YJ7gMl5umJKrtBgJj9TthGXyefSanM6x GMzH3VPWzzOeFBVHBoEGNefq5hWwprgCEqDqe/OhUe+2lONhaFJV9CBUXaLlPRNAyod1 ahgg== X-Gm-Message-State: AOAM533ikREpWXnx4Ztpi+L8zrqjqOEcEPRQ4coBiUkpydZvbLZ9cEpW OcNeyqNKSA4sJWoXfETssvMwNQFC4kE= X-Google-Smtp-Source: ABdhPJzV9WW2nhR+L8C+7aZqqMMVQDrAxdKBhLg6Wt72JUajXvxgdAKfRo+Jhcn/GmFN9j7xlT1N2g== X-Received: by 2002:adf:8091:: with SMTP id 17mr5315729wrl.457.1637837221845; Thu, 25 Nov 2021 02:47:01 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb50:e24a:add5:5ee1:31a8]) by smtp.gmail.com with ESMTPSA id a1sm3253114wri.89.2021.11.25.02.47.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 02:47:01 -0800 (PST) In-Reply-To: <87fsrkzfq1.fsf@yahoo.com> (Po Lu's message of "Thu, 25 Nov 2021 18:34:14 +0800") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::431 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=rpluim@gmail.com; helo=mail-wr1-x431.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280094 Archived-At: >>>>> On Thu, 25 Nov 2021 18:34:14 +0800, Po Lu said: Po> Robert Pluim writes: Po> Add support for pixel wheel deltas on NS >>=20 Po> * src/xterm.c (x_coalesce_scroll_events): Update doc string. Po> * src/nsterm.c (- mouseDown): Report pixel scroll deltas. >> nsterm.m, not .c. I guess you didn=CA=BCt use C-x 4 a to write the l= og >> message. Po> That's right. Good catch, sorry, but I couldn't get Po> add-change-log-entry to fill entries satisfactorily for use with Gi= t. add-change-log-entry doesn=CA=BCt need to fill the entry. You can refill in the *vc-log* buffer when committing. Or recentish versions of magit have a 'magit-generate-changelog' command. (please don=CA=BCt tell me you=CA=BCre not using Emacs to commit changes :-) ) Po> + Po> + DEFVAR_BOOL ("x-coalesce-scroll-events", x_coalesce_scroll_event= s, Po> + doc: /* SKIP: real doc in xterm.c. */); Po> + x_coalesce_scroll_events =3D true; Po> + >> We now have 3 definitions of x-coalesce-scroll-events. Is there not >> somewhere more generic where you can put it? (and I suspect we can >> drop the x- bit). Po> Not until MS-Windows gains this support, I think. I=CA=BCm sure we have similar variables already, but none spring to mind :-) Robert --=20