From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: Compiler warnings in dispnew.c Date: Sun, 28 Nov 2021 12:07:01 +0100 Message-ID: <87wnksfsiy.fsf@linux-m68k.org> References: <87fsrg7gdt.fsf.ref@yahoo.com> <87fsrg7gdt.fsf@yahoo.com> <83tufwwo7z.fsf@gnu.org> <87bl247dbn.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18702"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 28 12:07:57 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mrI2G-0004gp-Vl for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Nov 2021 12:07:56 +0100 Original-Received: from localhost ([::1]:42214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrI2F-0003hR-M0 for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Nov 2021 06:07:55 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrI1W-00032d-Sn for emacs-devel@gnu.org; Sun, 28 Nov 2021 06:07:10 -0500 Original-Received: from mail-out.m-online.net ([212.18.0.9]:42266) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrI1U-0005Uk-CB; Sun, 28 Nov 2021 06:07:09 -0500 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4J25KM2LLrz1r86j; Sun, 28 Nov 2021 12:07:03 +0100 (CET) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4J25KM25Gvz1qqkC; Sun, 28 Nov 2021 12:07:03 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id r44435d_rAwv; Sun, 28 Nov 2021 12:07:02 +0100 (CET) X-Auth-Info: etoS4s4mlmis7aa3YGNZ0wmmSmM6Ie563EJB/4NyxOsuQGVRiUFrf2WKxkE496YT Original-Received: from tiger.home (ppp-46-244-189-195.dynamic.mnet-online.de [46.244.189.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sun, 28 Nov 2021 12:07:02 +0100 (CET) Original-Received: by tiger.home (Postfix, from userid 1000) id E98047A915; Sun, 28 Nov 2021 12:07:01 +0100 (CET) X-Yow: PIZZA!! In-Reply-To: <87bl247dbn.fsf@yahoo.com> (Po Lu's message of "Sun, 28 Nov 2021 19:02:36 +0800") Received-SPF: pass client-ip=212.18.0.9; envelope-from=whitebox@nefkom.net; helo=mail-out.m-online.net X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280397 Archived-At: Does that work? diff --git a/src/dispnew.c b/src/dispnew.c index f3f110a8f2..a976bf94c5 100644 --- a/src/dispnew.c +++ b/src/dispnew.c @@ -1034,7 +1034,7 @@ copy_row_except_pointers (struct glyph_row *to, struct glyph_row *from) { enum { off = offsetof (struct glyph_row, x) }; - memcpy (&to->x, &from->x, sizeof *to - off); + memcpy ((char *) to + off, (char *) from + off, sizeof *to - off); } Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."