From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: Correct byte compiler error/warning positions. The solution! Date: Tue, 30 Nov 2021 10:52:40 +0100 Message-ID: <87wnkq3r87.fsf@gmail.com> References: <83pmqm16vz.fsf@gnu.org> <8335nh29pt.fsf@gnu.org> <83wnktzxb2.fsf@gnu.org> <83ilwcyc6o.fsf@gnu.org> <87v90b5c2o.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23745"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 30 10:53:34 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mrzpN-0005xh-I2 for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Nov 2021 10:53:33 +0100 Original-Received: from localhost ([::1]:58718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrzpM-0001yf-F6 for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Nov 2021 04:53:32 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrzod-0001K1-25 for emacs-devel@gnu.org; Tue, 30 Nov 2021 04:52:48 -0500 Original-Received: from [2a00:1450:4864:20::430] (port=37656 helo=mail-wr1-x430.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrzoa-0003WK-NO; Tue, 30 Nov 2021 04:52:46 -0500 Original-Received: by mail-wr1-x430.google.com with SMTP id d9so22193709wrw.4; Tue, 30 Nov 2021 01:52:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=LTJOeknuzGWgINi+lIkvZUMQPwOQ17mCY1yq5LNrIJE=; b=LGRsj3er8/fVUPZwqOniIavO0MXsJC13aUbM9zmTYgc+iAtcLPRvXKP4fAmsDnvVol mec7p98KG/7K3a8OHgAHxTNkbkPkUuB1iRnZNbtwLY4Rc0bY+XuisQ23oPbbhq4/peM/ qB8N5u3SsWkMBhD6PupIAkP2fHEfqiInmgu1nDfZ4bmCYfYK9lrvLUz/vIZ6Mp4ouAnr lTR9uhU/vG01adzT9+YGGLDTiHAkvCSJk6UKlvfBxi0IBAn6cgVktXPvJSuceZcxVqp9 zDDJwky5XuaGylJ1Zrr+CzjGlmOkasXElBZPToS1TG7NjywgzGpUUKrpGbIB5VKgFtRe /U7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=LTJOeknuzGWgINi+lIkvZUMQPwOQ17mCY1yq5LNrIJE=; b=Jp7j2ipv6z8Jd9fMztXhKxvcGEu3YhItJuIy1/z3OfkwHsyCmmCGHSJ45QcUBRPavG rnszqNV/7H2KT9KjK4VpVugjJvM1aTS4EN2NDq+bNfPTU+gAYemPLret4GIHBtoC6q4n qeV8X3zaYxT0EJcduB0iuAnHREede6aWYutgQXh4ZVhUOvVdApgCxuXeuhxyXHZWyv0r JomuQ8EQPsWpxTyurOnrC4QrwWc1MUyQPHqAesTOAt2wDgG4Pl1u1rjbfMDePDe46JbF xXnG5JTN2XEize9c2FoCuMaOeG9R/jQko8nN3nrDD1G4OvbCRLiE1OdI6jZQxv9vxc9p xRZw== X-Gm-Message-State: AOAM532WqxTzuJGYFrxl/smihzIvZ9s5xR0edaa3kOipkiLGPVIWEUMJ SIu3vE1Ezff8eiZOSwNqGi6smrbfUok= X-Google-Smtp-Source: ABdhPJwywvIl+oz8/8NVIs4LMabpG4y/c69tT93M7fusv7LwVrYeinicUjO9bi2Co8TZecRfv6o1Hg== X-Received: by 2002:adf:d1cb:: with SMTP id b11mr39566734wrd.33.1638265961897; Tue, 30 Nov 2021 01:52:41 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb50:452b:223a:73d6:af90]) by smtp.gmail.com with ESMTPSA id o9sm16087810wrs.4.2021.11.30.01.52.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 01:52:41 -0800 (PST) Gmane-Reply-To-List: yes In-Reply-To: (Alan Mackenzie's message of "Mon, 29 Nov 2021 19:16:26 +0000") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::430 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=rpluim@gmail.com; helo=mail-wr1-x430.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280528 Archived-At: >>>>> On Mon, 29 Nov 2021 19:16:26 +0000, Alan Mackenzie said: Alan> Yes. I think the patch below will fix this. Alan> I must admit, I didn't know about --enable-check-lisp-object-type= . When Alan> I tried it out with the fixed lisp_h_EQ, I got lots of other warn= ings. Alan> But this option generates slower code. On a 20 second benchmark,= the Alan> code was ~0.5s slower than when compiled without the option. This Alan> probably shouldn't happen, and I don't know why it does. It=CA=BCs a mandatory option to test when making changes to lisp object representation, but you wouldn=CA=BCt use it in production, so it doesn=CA= =BCt matter if it=CA=BCs slightly slower. Alan> I need to tidy up the backslashes too. Alan> Anyhow, here's the patch which at least keeps the compiler messag= es as Alan> warnings: I=CA=BCm not getting any warnings at all with that patch, and the resulting Emacs seems to work ok. Robert --=20