From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= Newsgroups: gmane.emacs.devel Subject: Re: Oddities in ./configure --with-pgtk's output Date: Sun, 19 Dec 2021 13:49:20 +0100 Message-ID: <87wnk0wyi7.fsf@gmail.com> References: <878rwguchm.fsf@gmail.com> <87ee6899dd.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17680"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 19 13:51:34 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myvf3-0004Pq-4V for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Dec 2021 13:51:33 +0100 Original-Received: from localhost ([::1]:59530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myvf1-0008Tx-W2 for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Dec 2021 07:51:32 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myvd0-0007R7-Jx for emacs-devel@gnu.org; Sun, 19 Dec 2021 07:49:26 -0500 Original-Received: from [2a00:1450:4864:20::32a] (port=43629 helo=mail-wm1-x32a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1myvcx-0005zC-46 for emacs-devel@gnu.org; Sun, 19 Dec 2021 07:49:26 -0500 Original-Received: by mail-wm1-x32a.google.com with SMTP id o19-20020a1c7513000000b0033a93202467so4820222wmc.2 for ; Sun, 19 Dec 2021 04:49:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+DqHtUKlJy26mQ1NMRdmyxQZ3MoM2lyHL2+DJcvsqdI=; b=XBgcETb0yA6xxRduf8S2s5AK1BpV+SQ33IDm6dGgNjSWY7wiFPriEzInJK6p3KMHH5 OBP+zvRdVXDRQGxTn34RZ7AYLmDwnWSf2Ho8Jf/k99ims8Q3+/ujcymkS96jBWkaBupy x1utmJLP2b+rKP0xc+PQO5Q5pRQKz1SdGyy7dDNuUaQ9xqut4VeBOSRR8Uv3vSkHKEX2 Byu9AwjoxdntF0TAxY6nI6bjE+1Ta6rmpnD/LkZ4V+D/bv2qWd5KF/hP+XBkQmgIYT3P WtFUVunrEE+No1kwpbC/i+oZIneXGtAdOKdkrzHufRmwNf4QltjjQkWU7mNVPa9lM9rC yYRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=+DqHtUKlJy26mQ1NMRdmyxQZ3MoM2lyHL2+DJcvsqdI=; b=DOMNgfRZ/0llXubmsqP2eHSnpMC1GvQ+myEhajVnPIxKoZ/LAg1JSe0A8XYNwqQvF4 k08bfnvEA5FfvVB3pI+P+E30qPvj+1naFTdxZzbup+4Y/KdY3FFJpPdFHWHXVkb2IJrz nWdk3/J3Lh8EmMU6NblZZz00AOsBt8OmRDkt4dcSd0UhWt+TRMnt04ju3ImNIyKVg2KY 3xjI0WP7oZSmaX7o+yB695xcuN/kqvl2d2gLQOlXFYg2kihNLqXuFkcPwuub5wTAktDW jJjT0uvP+gDfpvD/4Yo6sQXIOq/knog5QgwK9AKcTz0XEmgj2DUbxjeBMzBYwVv8sct3 hmPA== X-Gm-Message-State: AOAM532RPicff4Q2AG/1cmszLHdnDzniJj9UPl2vAb4ZL7OTQV82kdG1 /dJvefnDGODp+7CuCjhOsYAYWQfQK3c= X-Google-Smtp-Source: ABdhPJzqdXD8jRQJ2yKPpHGiPAT84CfttVnwh4LU/2C9RFkPjUvifppt8ecQksJmaj1F4to/EjWC0Q== X-Received: by 2002:a05:600c:34c1:: with SMTP id d1mr12755924wmq.139.1639918161428; Sun, 19 Dec 2021 04:49:21 -0800 (PST) Original-Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id w11sm2911758wrn.65.2021.12.19.04.49.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Dec 2021 04:49:20 -0800 (PST) In-Reply-To: <87ee6899dd.fsf@yahoo.com> (Po Lu's message of "Sun, 19 Dec 2021 18:28:30 +0800") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::32a (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=kevin.legouguec@gmail.com; helo=mail-wm1-x32a.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:282423 Archived-At: --=-=-= Content-Type: text/plain Po Lu writes: >> IIUC 'configure' guards WebP support behind several 'test "${HAVE_XXX}"' >> clauses where XXX represents "something that supports displaying >> images". Should this be extended to ${HAVE_PGTK}? > > Could you try to extend it that way and test if the webp support works? > If it does, I will enable it for the PGTK build. Mmm. That was slightly more involved than I expected: - HAVE_PGTK is defined way after HAVE_WEBP is computed, - the HAVE_PGTK block seems to depend on $GTK_LIBS, so IIUC it should come after AC_SUBST(GTK_LIBS), - the part which performs AC_SUBST(GTK_LIBS) comes after the HAVE_WEBP block as well. The attached patch seems to work (I've ./configure'd --with-pgtk, webp support was added automatically, and visiting a webp file with the resulting Emacs successfully displays the image), but I have no idea how idiomatic my tweaks are. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment diff --git a/configure.ac b/configure.ac index 2e7ea2bd6f..d1a433a502 100644 --- a/configure.ac +++ b/configure.ac @@ -2315,6 +2315,8 @@ AC_DEFUN term_header=pgtkterm.h with_gtk3=yes USE_X_TOOLKIT=none + HAVE_PGTK=yes + AC_DEFINE([HAVE_PGTK], 1, [Define to 1 if you have pure Gtk+-3.]) ;; haiku ) term_header=haikuterm.h @@ -2677,7 +2679,7 @@ AC_DEFUN if test "${with_webp}" != "no"; then if test "${HAVE_X11}" = "yes" || test "${opsys}" = "mingw32" \ || test "${HAVE_W32}" = "yes" || test "${HAVE_NS}" = "yes" \ - || test "${HAVE_BE_APP}" = "yes"; then + || test "${HAVE_BE_APP}" = "yes" || test "${HAVE_PGTK}" = "yes"; then WEBP_REQUIRED=0.6.0 WEBP_MODULE="libwebp >= $WEBP_REQUIRED" @@ -2950,8 +2952,6 @@ AC_DEFUN if test "$window_system" = "pgtk"; then PGTK_OBJ="pgtkfns.o pgtkterm.o pgtkselect.o pgtkmenu.o pgtkim.o xsettings.o" PGTK_LIBS="$GTK_LIBS" - HAVE_PGTK=yes - AC_DEFINE([HAVE_PGTK], 1, [Define to 1 if you have pure Gtk+-3.]) fi AC_SUBST(PGTK_OBJ) AC_SUBST(PGTK_LIBS) --=-=-=--