From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Newsgroups: gmane.emacs.devel Subject: Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' Date: Tue, 28 Dec 2021 23:59:13 +0100 Message-ID: <87wnjoibem.fsf@miha-pc> References: <164073060906.21430.4993248796177370312@vcs2.savannah.gnu.org> <20211228223009.6D0BAC002EE@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18008"; mail-complaints-to="usenet@ciao.gmane.io" To: Dmitry Gutov , emacs-devel@gnu.org, Sam Steingold Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 28 23:56:24 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2LOK-0004XS-2w for ged-emacs-devel@m.gmane-mx.org; Tue, 28 Dec 2021 23:56:24 +0100 Original-Received: from localhost ([::1]:54466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2LOI-000454-Gy for ged-emacs-devel@m.gmane-mx.org; Tue, 28 Dec 2021 17:56:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2LLg-0003Gg-Sp for emacs-devel@gnu.org; Tue, 28 Dec 2021 17:53:40 -0500 Original-Received: from kamnitnik.top ([209.250.245.214]:36066) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2LLd-0002Vw-GR for emacs-devel@gnu.org; Tue, 28 Dec 2021 17:53:39 -0500 Original-Received: from localhost (BSN-77-156-43.static.siol.net [193.77.156.43]) by kamnitnik.top (Postfix) with ESMTPSA id 8FD0B9C9CD; Tue, 28 Dec 2021 22:53:32 +0000 (UTC) In-Reply-To: Received-SPF: none client-ip=209.250.245.214; envelope-from=jakanakaevangeli@chiru.no; helo=kamnitnik.top X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283523 Archived-At: Dmitry Gutov writes: > Hi Sam, > > On 29.12.2021 01:30, Sam Steingold wrote: >> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el >> index 3b634471ac..62dba7b393 100644 >> --- a/lisp/progmodes/project.el >> +++ b/lisp/progmodes/project.el >> @@ -1015,7 +1015,7 @@ if one already exists." >> (default-project-shell-name (project-prefixed-buffer-name "shell")) >> (shell-buffer (get-buffer default-project-shell-name))) >> (if (and shell-buffer (not current-prefix-arg)) >> - (pop-to-buffer-same-window shell-buffer) >> + (pop-to-buffer shell-buffer display-comint-buffer-action) >> (shell (generate-new-buffer-name default-project-shell-name))))) >> >> ;;;###autoload >> @@ -1031,7 +1031,7 @@ if one already exists." >> (eshell-buffer-name (project-prefixed-buffer-name "eshell")) >> (eshell-buffer (get-buffer eshell-buffer-name))) >> (if (and eshell-buffer (not current-prefix-arg)) >> - (pop-to-buffer-same-window eshell-buffer) >> + (pop-to-buffer eshell-buffer display-comint-buffer-action) > > Please add boundp fallbacks: project.el should retain compatibility with > older Emacs releases. Also here: > diff --git a/lisp/shell.el b/lisp/shell.el > index 370532ea46..1860e4691d 100644 > --- a/lisp/shell.el > +++ b/lisp/shell.el > @@ -758,7 +758,7 @@ shell > (current-buffer))) > ;; The buffer's window must be correctly set when we call comint > ;; (so that comint sets the COLUMNS env var properly). > - (pop-to-buffer-same-window buffer) > + (pop-to-buffer buffer) > > (with-connection-local-variables > ;; On remote hosts, the local `shell-file-name' might be useless. should probably be (pop-to-buffer buffer display-comint-buffer-action) to make it analogous to the other changes in the patch.