unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: Po Lu <luangruo@yahoo.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: Re: master ad2d50d762: Fix last change in xterm.c
Date: Mon, 21 Feb 2022 09:39:03 +0100	[thread overview]
Message-ID: <87wnhosjfc.fsf@igel.home> (raw)
In-Reply-To: <87fsodjbe6.fsf@yahoo.com> (Po Lu's message of "Mon, 21 Feb 2022 08:45:05 +0800")

On Feb 21 2022, Po Lu wrote:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> I have no idea whether it's this change that caused it or not, but:
>>
>> xterm.c: In function ‘handle_one_xevent’:
>> xterm.c:8880:3: warning: macro expands to multiple statements [-Wmultistatement-macros]
>>  8880 |   if (temp_index == ARRAYELTS (temp_buffer))                          |   ^~
>> xterm.c:8880:3: note: in definition of macro ‘STORE_KEYSYM_FOR_DEBUG’
>>  8880 |   if (temp_index == ARRAYELTS (temp_buffer))                          |   ^~
>> xterm.c:10125:13: note: some parts of macro expansion are not guarded by this ‘for’ clause
>> 10125 |             for (i = 0; i < nbytes; i++)
>>
>> I get these warnings when compiling now with nativecomp, and I don't
>> think they were there a couple of days ago?  But I may be mistaken.
>
> That's odd, since that code has been there forever.

That's not true, see commit 0a9c8855b0.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."



  reply	other threads:[~2022-02-21  8:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <164471287374.8915.7898836027190086271@vcs2.savannah.gnu.org>
     [not found] ` <20220213004114.975FDC00891@vcs2.savannah.gnu.org>
2022-02-20 16:27   ` master ad2d50d762: Fix last change in xterm.c Lars Ingebrigtsen
2022-02-20 16:43     ` Eli Zaretskii
2022-02-20 17:13       ` Lars Ingebrigtsen
2022-02-21  0:45     ` Po Lu
2022-02-21  8:39       ` Andreas Schwab [this message]
2022-02-21 14:07       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnhosjfc.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).