unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Matthias Meulien <orontee@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: emacs-devel@gnu.org
Subject: Re: Fix width tabs
Date: Mon, 21 Feb 2022 13:38:36 +0100	[thread overview]
Message-ID: <87wnho9yyb.fsf@gmail.com> (raw)
In-Reply-To: <86fsock4f1.fsf@mail.linkov.net> (Juri Linkov's message of "Mon,  21 Feb 2022 10:30:27 +0200")

Juri Linkov <juri@linkov.net> writes:

>>>> If you want, you could try experimenting by writing a function
>>>> for tab-bar-tab-name-function with padding every tab name
>>>> by proportional amount of space.
>>>
>>> I'll try this. Thanks a lot!
>>
>> If you need the fixed width also for tabs with explicit names,
>> then a better option would be write a formatting function for
>> tab-bar-tab-name-format-function.

I tried the following (not trying to dynamically compute the tabs width
to start with and disabling support for close buttons):

(defun my-tab-bar-tab-name-format (tab i)
  (propertize
   (truncate-string-to-width
    (format
     (concat "%-" (number-to-string tab-bar-tab-name-truncated-max) "s")
     (alist-get 'name tab))
    tab-bar-tab-name-truncated-max 0 ?m t)
   'face (funcall tab-bar-tab-face-function tab)))

(setq tab-bar-tab-name-format-function 'my-tab-bar-tab-name-format)

Unfortunately it doesn't play well with variable pitch font, and the
display property "min-width" isn't honored in tab-bar. I guess my naive
approach won't be sufficient...

> OTOH, I can't imagine how you could implement a formatting function
> without requiring two-pass tabs generation that is highly inefficient:
> after the first pass you get the number of tabs, groups of tabs,
> and their names.  Then on the second pass you can pad names
> with required amount of space proportional to the total number of tabs.
>
> So a more efficient implementation would be to modify the strings
> that represent the tab names in the result of tab-bar-format-list
> (e.g. by using advice-add for experimentation).  But a drawback is
> that then you need to rely on the details of implementation of the
> internal data structure.

I understand.
-- 
Matthias



  reply	other threads:[~2022-02-21 12:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-17 21:31 Fix width tabs Matthias Meulien
2022-02-18  7:49 ` Juri Linkov
2022-02-18 14:45   ` Matthias Meulien
2022-02-19 17:05     ` Juri Linkov
2022-02-21  8:30       ` Juri Linkov
2022-02-21 12:38         ` Matthias Meulien [this message]
2022-02-22 17:18           ` Juri Linkov
2022-10-27  7:40         ` Juri Linkov
2022-10-30 19:50           ` Matthias Meulien
2022-11-02 18:01             ` Juri Linkov
2022-11-04  7:48               ` Juri Linkov
2022-11-04  8:07                 ` Eli Zaretskii
2022-11-05 17:12                   ` Juri Linkov
2022-11-05 17:28                     ` Eli Zaretskii
2022-11-05 18:20                       ` Juri Linkov
2022-11-05 17:56                     ` tomas
2022-11-05 18:17                       ` Juri Linkov
2022-11-06 10:59                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnho9yyb.fsf@gmail.com \
    --to=orontee@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).