From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yoav Marco Newsgroups: gmane.emacs.devel Subject: Re: Tree-sitter integration on feature/tree-sitter Date: Tue, 28 Jun 2022 22:35:52 +0300 Message-ID: <87wnd0pokm.fsf@gmail.com> References: <874k04lp9x.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14619"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.6.3; emacs 29.0.50 Cc: Eli Zaretskii , Theodor Thornhill , Stefan Monnier , Daniel Colascione , emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 29 04:23:14 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o6NMH-0003cO-Nb for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Jun 2022 04:23:13 +0200 Original-Received: from localhost ([::1]:57756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o6NMG-0004Hj-7G for ged-emacs-devel@m.gmane-mx.org; Tue, 28 Jun 2022 22:23:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6H1I-0005Pl-NH for emacs-devel@gnu.org; Tue, 28 Jun 2022 15:37:10 -0400 Original-Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:46669) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o6H1B-0002ys-Vo; Tue, 28 Jun 2022 15:37:08 -0400 Original-Received: by mail-wr1-x432.google.com with SMTP id i25so13644276wrc.13; Tue, 28 Jun 2022 12:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=uvU157IGo+FGZQCh/oRMg/zXi9o13VWj2OjNojdaLt0=; b=bBsCbtaokRgYQAv/EE0wRQG5OvMd6A7jV2v+EeGY3wV6u/gjxbHOYwrmzP6jnUf+eT C8n0aDLo2Wdm65WvjJGm/eJ45bpieAlY3H/EVPTQZvp52YRYYuKLVxNElMfKED6jpOHN nRperJ0hL22QGB2hm5GEXVwvyfFlTg94j7tpjV8jAxCufWNwV26k30SL2A/aUMmoK0Xc B93l7A1KLL6hueRcyl+r8iJwzsOwuElD/ddrsigtz7RBGoF2LryCwr0AOLYlThWO6+e/ n+mSFCbXZvgv4a+GBl8/TMzqKgTFGlZLDNOAmVZ8vFW3FjXPgP47iGDFmSX4YtDPQCK6 gY1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=uvU157IGo+FGZQCh/oRMg/zXi9o13VWj2OjNojdaLt0=; b=7Ziqsj0zlJQdWf6KXp8VrnvQOb4krRSWJT5cbyzRSxuYB8RjiuvIxE+IH3EqubhBTq LNKfaPqyBfISBMu7b3VtHIsRrwg2R4MzPRI1kaUWTmaDfajNDm3LnVoa2mB7Re2KN180 JvSRqxoy3mSxoedyQSPJ40KxdMOJbzeMysXNt/0sM04a5xuhyUpubZsQXfe26jxFk0S/ LwuA//NYkFvuNX+H7wKsT8pKrC8KLkE6pjUz25h3x22AJoNpCg6WUjJ0FTlmryl+eGIt b1gEGdstsQ4ANAwffIV965aJnNWGQ43CRpXw4NP4oIjohbD5NOyd0cBph9rNWXVTkHHa LACw== X-Gm-Message-State: AJIora8Nq+NKDAS7uOW6Ahw/acz5Uk51Te8Uo47RnyqJZVGfGrHUohFd OrkW8yKFYfp6K1wzDh+F0u0= X-Google-Smtp-Source: AGRyM1smuGnGBgf2a0IUVbqJHprZkRiDjXM5fUBkuy/Ce5i7zEt5zFs+T1li6PmXPPiRkXVWU6Lk8Q== X-Received: by 2002:adf:ffc5:0:b0:21b:bfd5:caf7 with SMTP id x5-20020adfffc5000000b0021bbfd5caf7mr18550028wrs.353.1656445020260; Tue, 28 Jun 2022 12:37:00 -0700 (PDT) Original-Received: from localhost ([77.126.160.145]) by smtp.gmail.com with ESMTPSA id 129-20020a1c1987000000b0039c4945c753sm469088wmz.39.2022.06.28.12.36.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 12:36:59 -0700 (PDT) In-reply-to: <874k04lp9x.fsf@gmail.com> Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=yoavm448@gmail.com; helo=mail-wr1-x432.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 28 Jun 2022 22:21:14 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291704 Archived-At: Whoops, my mail turned out garbaled, sorry. Corrected version: Yuan Fu writes: >>> Also I think it makes more sense if you just fork it rather than making a PR. >> >> Yeah, I don't really expect it to be merged. >> >> My reason for the PR is for it to be more of a talking point about >> collaboration between treesit and tree-sitter-langs. I used >> elisp-tree-sitter before trying the feature/tree-sitter branch, and I >> really like the richness of its highlighting (which comes from the >> highlights.scm files). > > Do you already have the highlighting working for treesit? I only checked a few, but yeah, and the syntax highlighting is very pretty. > If so, maybe you can packages it in a separate package and publish it, > it would be a nice demonstration of treesit features. I'm not comfortable with doing that, the query patterns update frequently upstream (though ubolonton has been busy lately) and all I'm doing is post-process them a little. I could try to make a self-updating repo or something with CI - https://github.com/meain/evil-textobj-tree-sitter for example pulls highlights.scm changes from nvim's repo weeky. Is that worth it? I thought people could just as easily use my PR branch of tree-sitter-langs. That also takes care of fetching grammars. Sorry for the late response, Yoav