From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud Newsgroups: gmane.emacs.devel Subject: Re: How to walk a Lisp_String? Date: Fri, 02 Sep 2022 09:18:59 +0200 Message-ID: <87wnam6y70.fsf@elite.giraud> References: <87a67jw1kw.fsf@elite.giraud> <83o7vzqey8.fsf@gnu.org> <83mtbjqemd.fsf@gnu.org> <87ler2963r.fsf@elite.giraud> <838rn2qnsf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22600"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 02 09:22:16 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oU10I-0005hT-DB for ged-emacs-devel@m.gmane-mx.org; Fri, 02 Sep 2022 09:22:14 +0200 Original-Received: from localhost ([::1]:35618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oU10H-00022i-CG for ged-emacs-devel@m.gmane-mx.org; Fri, 02 Sep 2022 03:22:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oU0xH-0008Ga-8b for emacs-devel@gnu.org; Fri, 02 Sep 2022 03:19:12 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:10510) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oU0xF-0007oB-8K; Fri, 02 Sep 2022 03:19:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=YjXGIuRREK7CRZUz bNygPnMzivUYGNx5lMCT2arEIxw=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=PAithIjwj2hv+IvB9OAd3lCVAmxXu3ifG3gSr4 CVmKHVB2gCQsDI7yx+Zrmxy6rccQeBnPtkpaiVagZC6rAPOPqnNRk1WAEqRFgezfLDD/u7 6kSiey2PrODWlOTMAdj51l9DEOgyAdsKcqCtyrdhIwzebV7fWUyG0rlrjbKMzv38fw78am +085mcE17MPadP5RzHHE688zmhBkoQOkgsr6HXV9+270OjIrc5FhbzebG4tHW0rXxgujk2 oehwQJRomq9ZkTxA93LKB3f1R6Al7tQDuGjfCsiuKEe4ryT14C+oVznVt884xl69QxG3Br z7G99k8bDKelT+020hdfr7AQ== Original-Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 5bc5d8fd (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 2 Sep 2022 09:19:00 +0200 (CEST) In-Reply-To: <838rn2qnsf.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 02 Sep 2022 09:43:28 +0300") Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294516 Archived-At: Eli Zaretskii writes: >> From: Manuel Giraud >> Cc: emacs-devel@gnu.org >> Date: Thu, 01 Sep 2022 22:45:12 +0200 >> >> I'm working into lwlib only. So I've made a function to get the frame >> of the menu widget (mw). I'm also converting the char* display_string >> of each menu entry to a Lisp_String with make_string (note: I don't know >> if I should have done that but it seems the way to get a proper >> multi-byte string from a char*). > > make_multibyte_string is better, I think. make_string seems to be a higher level interface: it calls make_unibyte_string or make_multibyte_string whether the string is uni- or multi-byte. > And I don't think I understand how you get the Lisp string to have the > face information. The original C char* string cannot have that > information as part of the string's data, so where will the face data > for the Lisp string come from? I don't understand your question. I thought it was the job of FACE_FOR_CHAR: you give it a char and a frame and it returns the face for this char in this frame. What am I missing? [...] > For the faces part, I think face_at_string_position is a better > interface. It returns a face ID, from which you can get to the > corresponding 'struct face' via FACE_FROM_ID. Thanks, it is a much better interface. -- Manuel Giraud