From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: bug#58799: Make winner key sequences repeatable in repeat-mode Date: Mon, 31 Oct 2022 16:09:54 +0100 Message-ID: <87wn8gni65.fsf@gmail.com> References: <87y1t2zl1s.fsf@cassou.me> <87fsf9vdr6.fsf@gmail.com> <87v8o5ts06.fsf@gmail.com> <87lep1tmie.fsf@gmail.com> <871qqss31s.fsf@gmail.com> <87a65coytd.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9557"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 31 16:11:33 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1opWRo-0002Mm-VA for ged-emacs-devel@m.gmane-mx.org; Mon, 31 Oct 2022 16:11:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1opWQK-0000ZF-IM; Mon, 31 Oct 2022 11:10:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opWQJ-0000Yi-1I for emacs-devel@gnu.org; Mon, 31 Oct 2022 11:09:59 -0400 Original-Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1opWQH-0001qI-Gd for emacs-devel@gnu.org; Mon, 31 Oct 2022 11:09:58 -0400 Original-Received: by mail-wr1-x42c.google.com with SMTP id g12so16393115wrs.10 for ; Mon, 31 Oct 2022 08:09:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=zFdDi7nbhY8EDj5FP88S3iIb3uiN3dQcANYqOXWGRCQ=; b=LL8iVpnHhdyUhs/HK3t3ViD+NCaUyl4jGu+twGs6UHV2F7ZpZSloUoUWGwX+1eEyv4 sRZFJkpDaNlcozRjrxRXKlpencl8oWh6l+aTvm6xJ7mnmDtgu1Y5K4KEvQshXZ8THHXS 1yoxSTZKP6OgXyQjCgq4HunMWP3ZYF7falbS7poxliv0QakpvwuqEVz73dSOCkr9yG/M wS04H9zAILh7EFx6VSKC/99YLdOYNWmSMUaJX7G/zA867VX7Zy81+BGFG0Se+yPYUfQl epieWvYwPtmV3gVcOPEA//v7ufFcQLm0mK2GQuovIcRT2cE9vD1BqL+qfULoucYFAuoz ZBQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zFdDi7nbhY8EDj5FP88S3iIb3uiN3dQcANYqOXWGRCQ=; b=oChvyl9VYA34Q9d8RF/4BYwu5Q8kGQlhFg2j5CvSqpd7ABw2da2FUQtJhDba4QP6jV keCf35tglQra9cHUS/6VfEcIKIHtj5eNJbPOol7cfate+gYzmPuW3+GA4bxrOvWc5uHg 4KjU857QtNkqVhBkyL2wzmlr7VeWqY07ZM3QjltSolqv1icPuj+Ekf9AT3JlFBZOZZYc xS7c29xQCx7iE6VDmJ4zBecnAdNjLKcNTOWQfdyPX+rn4ktIwe8Lil6VF2K9YKRXrEKT Hbtr90lD2YRBOEbseRcXch9jqNsRoOiHaCoCjwMxmGC4drXeXMrpsF0B+rIqrmQCqqSo CeGg== X-Gm-Message-State: ACrzQf1LmB0bmduYyfwFu9UZutyPaCWvcszuIdSPN9blnmhsPsJDuqo7 UDZRX7jmN10eMsT6H3SdhLjBqNCDIuU= X-Google-Smtp-Source: AMsMyM5PD89ZDjNVQfc/64FGIATzcnCUkvdXz5Aqo2mcSy4AgeklZserT/jq4uitKnfYEUGDcl2+fw== X-Received: by 2002:adf:db4d:0:b0:236:699b:be5e with SMTP id f13-20020adfdb4d000000b00236699bbe5emr8088120wrj.147.1667228995539; Mon, 31 Oct 2022 08:09:55 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id z17-20020a05600c0a1100b003b492753826sm7580349wmp.43.2022.10.31.08.09.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Oct 2022 08:09:54 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Mon, 31 Oct 2022 07:47:36 -0700") Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=rpluim@gmail.com; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298861 Archived-At: (redirecting to emacs-devel) >>>>> On Mon, 31 Oct 2022 07:47:36 -0700, Stefan Kangas said: Stefan> close 58799 29.1 Stefan> thanks Stefan> Robert Pluim writes: >> In any case, I think we can close this particular bug. Stefan> Agreed. Now done. So the minimal change I think is this: diff --git c/lisp/keymap.el i/lisp/keymap.el index 107565590c..750095fab4 100644 --- c/lisp/keymap.el +++ i/lisp/keymap.el @@ -545,6 +545,10 @@ define-keymap (let ((def (pop definitions))) (if (eq key :menu) (easy-menu-define nil keymap "" def) + (unless (key-valid-p key) + (error + "Key '%s' in keymap '%s' is not `key-valid-p'" + key keymap)) (if (member key seen-keys) (error "Duplicate definition for key: %S %s" key keymap) (push key seen-keys)) which will give a run-time error for things like "[left]" and '[left]', but that=CA=BCs redundant with the compile time warning: make[3]: Entering directory '/home/rpluim/repos/emacs/lisp=CA=BC ELC winner.elc In toplevel form: winner.el:314:15: Warning: Invalid =E2=80=98kbd=E2=80=99 syntax: "[left= ]" Eli? Lars? Is this overkill for such a rare case? Robert --=20