From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Removing packages from archive-contents if removed from elpa-packages Date: Mon, 31 Oct 2022 14:25:39 +0000 Message-ID: <87wn8ggjdo.fsf@posteo.net> References: <878rkwe3fv.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18519"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 31 15:26:36 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1opVkK-0004ad-0Z for ged-emacs-devel@m.gmane-mx.org; Mon, 31 Oct 2022 15:26:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1opVjl-0003cu-7v; Mon, 31 Oct 2022 10:26:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opVjj-0003Xa-KO for emacs-devel@gnu.org; Mon, 31 Oct 2022 10:25:59 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opVjT-00046R-0N for emacs-devel@gnu.org; Mon, 31 Oct 2022 10:25:59 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id ED2C7240101 for ; Mon, 31 Oct 2022 15:25:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667226341; bh=zDde5eLLo8Fxtkzm3CS1Q1+ojfijWachiQ9ZolPYHXs=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=K59SbmM9TPd4YE0Wto27sZGc6nDewLWI7Grk46ShIWaVq/X8ZpNHTsHL0jFq0FneC /DnK71HUGfurpyjl4Yp9wYc8ldz+QSFJzE+q5ZYbAHKQSDRfqieDCg+31uLMTn/wMH oX8Spxfv0fBYwub7Hqgui5SyZKTbXl0ZQevQ3znM8ajyfiz/SEMIJnjF/6daJnZAAT MVjHRrtGKP8aC0a0GOQMz5j9lW2EZN+HZpVnyayfzpTvXkqvyyKQ5CSAfkfrwKk+w2 gC9XlRPd6Y0hzRXdAwrI8lil+eI9/zq0Zb6YiT0jSmpZEOkBKAMUe4IWs0Gs3Dxjty JdzWmOBCfz0CQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N1Fn03dy8z9rxL; Mon, 31 Oct 2022 15:25:40 +0100 (CET) In-Reply-To: (Stefan Monnier's message of "Mon, 31 Oct 2022 08:11:59 -0400") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298856 Archived-At: Stefan Monnier writes: > Philip Kaludercic [2022-10-31 09:40:36] wrote: >> there is at least one broken package on NonGNU ELPA >> (color-theme-tangotango) that was added, then removed as dependencies >> were missing, but it remained in the archive because it was added to the >> archive-contents file. The following patch would make sure that any >> package not listed in elpa-packages is also remove from >> archive-contents: > > Thanks, but I don't think `elpaa--update-archive-contents` is the right > place for that. This can be called N times for a given invocation of > `elpaa-batch-make-all-packages`. > Why not call a dedicated function from `elpaa-batch-make-all-packages` > (i.e. alongside the call to `elpaa--publish-package-specs`)? That can be done. >> It might be a good idea to cache the interpretation of elpa-packages, so >> I would also suggest the following: > > Not sure it's worth the trouble: the way the code is written, it should > be called only once per Emacs session in the majority of cases, no? Right, ideally somewhen around the beginning. >> 1. This does not remove any tarballs. It wouldn't be hard to do, but I >> am not sure if there would be any unintended side effects of doing >> so -- at least immediately. > > I think we should keep the old HTML page and tarballs. I agree. >> 2. There are functioning packages on NonGNU ELPA like haskell-mode that >> were also added to elpa-packages then removed, and still linger in >> the archive without being updated. This would get rid of those too, >> which might not be a good idea. > > Indeed, `haskell-mode` should be re-added to `elpa-packages` > because IIRC it's still actively depended-upon (by GNU ELPA's `hcel`). The issue here is that upstream isn't responsive and has asked for haskell-mode to not be added until further notice :/