From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 3c1693d08b0: Fix Elisp code injection vulnerability in emacsclient-mail.desktop Date: Wed, 08 Mar 2023 18:20:14 +0100 Message-ID: <87wn3rnos1.fsf@gmail.com> References: <167821009581.14664.5608674978571454819@vcs2.savannah.gnu.org> <20230307172816.2D56BC13915@vcs2.savannah.gnu.org> <877cvsozn5.fsf@yahoo.com> <87zg8onfob.fsf@yahoo.com> <87r0tzoeam.fsf@yahoo.com> <87a60no7su.fsf@yahoo.com> <87edpzplom.fsf@gmail.com> <87a60npirc.fsf@gmail.com> <83mt4n49az.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40473"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , ulm@gentoo.org, luangruo@yahoo.com, emacs-devel@gnu.org To: Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 08 18:21:08 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZxTQ-000AII-QV for ged-emacs-devel@m.gmane-mx.org; Wed, 08 Mar 2023 18:21:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZxSf-0007g8-DG; Wed, 08 Mar 2023 12:20:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZxSe-0007g0-BN for emacs-devel@gnu.org; Wed, 08 Mar 2023 12:20:20 -0500 Original-Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZxSc-0001a8-DO; Wed, 08 Mar 2023 12:20:19 -0500 Original-Received: by mail-wm1-x334.google.com with SMTP id fm20-20020a05600c0c1400b003ead37e6588so1817540wmb.5; Wed, 08 Mar 2023 09:20:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678296016; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=XS5rsDsyrSqboCJjsXrVczQlN+bqrW7V8Sr194KJuX8=; b=GELSLOma8oDvnaZW6qKqLen8b887fkTFVd/VSd00uHKJk1t0neN+0ukKxO6g+/qokr X9e8f81OCH9XFrhOfiy0WgbqBZD+BnI7Je6nQFntHIBCKWoxbjVvQykG3tmAL1d0RxuZ r0ta+tR0NPzSGfIXZ4CRjRFTsMaiLEBiy9tYJJfK2JsNSQ95/AvxGQ6tWxJzt/v15IAU 2v9BSfCF5kAeZkVHsTzoEw+NZWT3guwTeNU5EZRRPPC+unZVFYtL4XZy3RmLHl55Hy4O KLDuDR8pX3ItXgOponKO7ERZ8K4sNxMAe3anQ220DZCCAueHHrizWuf6b5fAENAwvlDL 0fqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678296016; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XS5rsDsyrSqboCJjsXrVczQlN+bqrW7V8Sr194KJuX8=; b=rkbtMCglobjbtiT/rzKbUFspi5CiUARzsmRCqtZQDz2NCpbwR4Z+Zn52coGugsvh4l 41LvDlqlIkCNE1HoOgbQHrvONTISXVdp6HyGgMhuwQluDVmv7Mp/g9RSF/+2wYxAqsBH V3WpeFo6zXIyMNOoDtkXm3vLUZf0tjD69LttVYwMtHnQu8tHLkkv9cyaZi9pKfHnHkAP 6p5Rsp+rciOoDDzUkOkrlkWbKnYDnL14AB3ppYBeRh/iMUIakhWHjxI6er3raolNV+/m jaPmssa2B5Z3mPqzgPHeQiqDHX7xT5sqLDVyCukkug2n+R6ytZiUG2mEnb1ps0YKgQrh M5VA== X-Gm-Message-State: AO0yUKVsMqOSzHuzdVARS8auIsN5LkMXyRPuZYXHCsTa4WiIe60qa6dd jPrJtKRlM5dn7vacOC7PhVGHjNwh2f4= X-Google-Smtp-Source: AK7set+mmMBZzjuQrro1ZVasGYQnznbxf4QLohGnGotmSxH0FxeUUOdNM9M1ChVwqvMZAQtTDHQXhQ== X-Received: by 2002:a05:600c:3b02:b0:3eb:f73a:cf89 with SMTP id m2-20020a05600c3b0200b003ebf73acf89mr5349767wms.8.1678296015853; Wed, 08 Mar 2023 09:20:15 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id k23-20020a05600c1c9700b003e21f01c426sm81224wms.9.2023.03.08.09.20.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 09:20:15 -0800 (PST) In-Reply-To: (Jim Porter's message of "Wed, 8 Mar 2023 09:03:30 -0800") Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=rpluim@gmail.com; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304147 Archived-At: >>>>> On Wed, 8 Mar 2023 09:03:30 -0800, Jim Porter = said: Jim> On 3/8/2023 6:17 AM, Eli Zaretskii wrote: >>> From: Robert Pluim >>> Cc: Po Lu , emacs-devel@gnu.org >>> Date: Wed, 08 Mar 2023 12:47:19 +0100 >>>=20 >>> We can then add `--funcall' to emacs-30, and revisit this there. >> Fair warning: I will object to adding --funcall just for this niche >> problem. We didn't reach an agreement about --funcall at the time, >> and for good reasons; this particular use case does absolutely nothi= ng >> to change the outcome of that discussion. Jim> In bug#57752, we'd discussed adding --apply to emacs and emacsclie= nt, Jim> which might work better for this case, as well as to make other Jim> similar cases easier: Org mode uses some pretty extensive hacks in Jim> order to get org-protocol:// URLs working in emacsclient, and Jim> eliminating that would be very nice. Thanks for the reference. I=CA=BCve re-read the report, and the sort-of-consensus was that we needed '--apply' and a `set-arg' function. Eli, would that be acceptable? (my patch called `apply' anyway, so it=CA=BCs not too big a change :-) ) Robert --=20