From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: Merging feature/android Date: Tue, 14 Mar 2023 12:05:47 +0100 Message-ID: <87wn3jtwxg.fsf@gmail.com> References: <87edq7ztks.fsf.ref@yahoo.com> <87edq7ztks.fsf@yahoo.com> <874jqn9508.fsf@yahoo.com> <875yb3vftq.fsf@gmail.com> <87zg8f7h2d.fsf@yahoo.com> <871qlrvcc7.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30511"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 14 12:06:48 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pc2US-0007lZ-D7 for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Mar 2023 12:06:48 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pc2Tn-0004FJ-GD; Tue, 14 Mar 2023 07:06:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pc2Ti-0004Ed-Fe for emacs-devel@gnu.org; Tue, 14 Mar 2023 07:06:03 -0400 Original-Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pc2Tf-0005T6-Ne for emacs-devel@gnu.org; Tue, 14 Mar 2023 07:06:02 -0400 Original-Received: by mail-wm1-x32a.google.com with SMTP id o38-20020a05600c512600b003e8320d1c11so508969wms.1 for ; Tue, 14 Mar 2023 04:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678791948; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=Zwy1hQC5w96GwPcDgibjz6y70fO9LRSeQiUINl9sDGA=; b=Vl6bKf27cWYSZtUTsK1C3XwFXIi4xjHOfs9t8osK92rNdPUOVoFG+C51ePiZMz4qqM 29HmSQ5oe5sC6sQaaeQ4qZ6WO2PcEcL0asrJEAIrSh/+r6ncV0jK1FubIbTaVSUki62w QNOzsjN8lAfC5zZBynO3b54L8D5FLr0MvXSI3YFxRHjAXtP71AxkcNkf0/TEe5k2pCUE zaTS2GNEnC5jbJmbrIfNfdptyH66qz6lF4XZL2hocJ8SlWZ2IGlCbg0mKEkc8s/tBA0L Q2Midx3EV2yKxSUziHSX5fkxzPNIVxZ+VQva4suGBGqcgf5WTNub1aUw1OUGKE2IDjVi hl0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678791948; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Zwy1hQC5w96GwPcDgibjz6y70fO9LRSeQiUINl9sDGA=; b=ch4R26rty6mg0msft5fZSHKNsJ+BboEKqkec5fyGCJJmM+7EMLXF4rbZSVpQoALT6/ YU3IihW3c7sP4bo9KT4tFvarf/W7sBHYG85hwY/sifGrrUoJ1v1b/zJHNj1wH7erWLrs HEmAZEzVnRFYzsqcUvU2wvlUdsEwH7D8cdF4MG7ELiYcXq/CDRDWL70UZ8eUn5LuS30A OzAgeNhouAQEbZx3EYwATi9U7LGm4zWttdPGRThv1bsft1wzMR5tkVs1C9AjgeNYxMFT nFkHxk3rG85KS9Xru0MniZOUUKzgh50R0W9FCb5hV6JOmdZF9WaVh7AVWHg4h2FsW43j rdBQ== X-Gm-Message-State: AO0yUKVS8m0DMkyNaEOBDa/HV3Usectb8ddNSBNxIDw2BZi9IqbFm/KJ /+G3RHyhmWMonvST7Y2xI/aaZwZTDvM= X-Google-Smtp-Source: AK7set8Juw1gZ6tCSxTr/4/+/yCFLnVPTUu7CJYDqB3GKXWIlZEp4VECy5o3Ac+cFiw8G8AMO3shGA== X-Received: by 2002:a05:600c:4708:b0:3ea:c100:f5e7 with SMTP id v8-20020a05600c470800b003eac100f5e7mr14218665wmo.39.1678791948241; Tue, 14 Mar 2023 04:05:48 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id a3-20020a05600c224300b003ed29189777sm2458427wmm.47.2023.03.14.04.05.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 04:05:47 -0700 (PDT) In-Reply-To: <871qlrvcc7.fsf@gmail.com> (Robert Pluim's message of "Tue, 14 Mar 2023 11:47:36 +0100") Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304430 Archived-At: >>>>> On Tue, 14 Mar 2023 11:47:36 +0100, Robert Pluim said: >>>>> On Tue, 14 Mar 2023 18:39:22 +0800, Po Lu said: >>> most of which are variants of >>> >>> Test simple-test-undo-extra-boundary-in-tex backtrace: >>> signal(error ("Invalid argument macro in `get-device-terminal'")) >>> apply(signal (error ("Invalid argument macro in `get-device-terminal Robert> Po Lu> If you could get a backtrace for this, it would be great. What is Robert> Po Lu> calling frames-on-display-list? Robert> Po Lu> Thanks. This fixes 3 of the 4 test failures: diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index ef0eb1ca108..cdff129b7a8 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -4598,9 +4598,10 @@ minibuffer-setup-on-screen-keyboard (cancel-timer minibuffer-on-screen-keyboard-timer) (setq minibuffer-on-screen-keyboard-timer nil)) (setq minibuffer-on-screen-keyboard-displayed nil) - (when (not (memq (device-class last-event-frame + (when (and (not (eq last-event-frame 'macro)) + (not (memq (device-class last-event-frame last-event-device) - '(keyboard core-keyboard))) + '(keyboard core-keyboard)))) (setq minibuffer-on-screen-keyboard-displayed (frame-toggle-on-screen-keyboard (selected-frame) nil)))) Robert --