From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuchen Pei Newsgroups: gmane.emacs.devel Subject: Re: 29.0.91 756244c696 Saving large org file can be slow with time-stamp before-save-hook Date: Tue, 13 Jun 2023 22:30:31 +1000 Message-ID: <87wn07bl3s.fsf@ypei.org> References: <87ilc4ok4d.fsf@ypei.org> <87pm6blp8u.fsf@localhost> <877cs8omhj.fsf@localhost> <8805E207-E121-43EE-A6CC-0EAA5758D3AD@ypei.org> <87cz20frb7.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23538"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Cc: emacs-devel@gnu.org To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 13 14:31:37 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q93BP-0005uS-I3 for ged-emacs-devel@m.gmane-mx.org; Tue, 13 Jun 2023 14:31:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q93AY-0001G9-RW; Tue, 13 Jun 2023 08:30:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q93AW-0001FV-26 for emacs-devel@gnu.org; Tue, 13 Jun 2023 08:30:40 -0400 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q93AT-0005Rs-W0 for emacs-devel@gnu.org; Tue, 13 Jun 2023 08:30:39 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 5C8EF5C027C; Tue, 13 Jun 2023 08:30:37 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 13 Jun 2023 08:30:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ypei.org; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1686659437; x=1686745837; bh=Ao casr92gYy/Hcren6MSE1jN7QHOnRUOTZqXaA5YNa0=; b=N0rCLI/pifoc+DYU6M 8z9zXAAUZAMmeasq1AWXUcfilOoHH6ei1ZoFzKltTj4lL3Ba4R+XznzPo+GTcXP9 eLcFuhsjAZx/au5Yr0EXoyU9AhfJsVr0Ky0qz+NjEi5NBUvxlM66jC+iZpz1yTUS 0SjlI2LvjYvnnya0Cw01iv9A2cM/hcJ5+lpdtZXPk/DMqj969BwOKwIrK0f4jXUA eNvkk5ZLTK65eDjJEtajPMUZ2xs/LZyG8q9GU5cHFw1G+U6P0xFohVVoj1HXNQ1l D1OU+4+U1Ox/fRkAeUe/1llGHXn1vk7cFRKJWuJhyOPq5ewVfdfeidLJQWhlmUuO Ov4A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1686659437; x=1686745837; bh=Aocasr92gYy/H cren6MSE1jN7QHOnRUOTZqXaA5YNa0=; b=Nr0lSMa4mVOB9zT0ttHTCR8REJCcF DiU4iq2QnowZMDI+xVL5/U7mPZWHYbty74IKnw4kBmhcJjqYv8r9wUFvCjK10o7s MgO6gaAr25vcr1RW1fEVfoqshrTgElZi7ag9z/iFzJyL6DZem/WFes6TiKnS4oqP Zy/0OxuateCfC6XO1ltZZEV2KJS2Nwsj3BXU5q7VWEqfoqA/nId8K4ClkHQ2V4dv a71RUowpsRe/LaQTYCNxmq15n3onwxwRkcWI8grM0sb+H42tdQNp1BfPmWOOHRKV BnQNh1Yb4oKK0s0+Pe8D2p1Z1Zsp/+7nJeRyQMvV6jwR44BTzYHsrsHzw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedujedggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufhfffgjkfgfgggtsehttd ertddtredtnecuhfhrohhmpegjuhgthhgvnhcurfgvihcuoehiugeshihpvghirdhorhhg qeenucggtffrrghtthgvrhhnpeefhefhkeejveeikeehjeeiueeftdegveeiveejkeelvd elfedufeeugfehteejudenucffohhmrghinhephihpvghirdhorhhgnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihguseihphgvihdrohhrgh X-ME-Proxy: Feedback-ID: i51b146f9:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 13 Jun 2023 08:30:35 -0400 (EDT) In-Reply-To: <87cz20frb7.fsf@localhost> (Ihor Radchenko's message of "Mon, 12 Jun 2023 18:50:36 +0000") Received-SPF: pass client-ip=66.111.4.29; envelope-from=id@ypei.org; helo=out5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306769 Archived-At: On Mon 2023-06-12 18:50:36 +0000, Ihor Radchenko wrote: > Yuchen Pei writes: > >>>On Emacs master. >>> >> >> Thanks for checking, but that is not the whole reprod process - it >> misses generating a big refile cache etc, see my original message. > > Ok. I tried to repeat your steps. > I was able to reproduce using Emacs 29 and some older build of Emacs 30. > But not on master. > > Profiler does not reveal anything, so it is somewhere in C internals. Thanks. What should be the next course of action to address this issue? I'd be happy to investigate and get it fixed in Emacs 29. Is it worth the effot to git-bisect to find the good commit? Best, Yuchen -- PGP Key: 47F9 D050 1E11 8879 9040 4941 2126 7E93 EF86 DFD0