From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Karthik Chikmagalur Newsgroups: gmane.emacs.devel Subject: Re: Proposal to add Popper to ELPA Date: Tue, 05 Sep 2023 13:49:29 -0700 Message-ID: <87wmx4cply.fsf@gmail.com> References: <874jk8ef0k.fsf@gmail.com> <87y1hkcygb.fsf@posteo.net> <255bb831-2309-764a-bb23-087ab267437b@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9855"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Mauro Aranda , Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 05 22:50:28 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdd0G-0002Ot-Dr for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Sep 2023 22:50:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdczP-0004D1-Nj; Tue, 05 Sep 2023 16:49:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdczO-0004Cr-Rb for emacs-devel@gnu.org; Tue, 05 Sep 2023 16:49:34 -0400 Original-Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdczM-0001vU-Pe for emacs-devel@gnu.org; Tue, 05 Sep 2023 16:49:34 -0400 Original-Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1c34c9cc9b9so10396295ad.3 for ; Tue, 05 Sep 2023 13:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693946971; x=1694551771; darn=gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=S6kVt6iBw47kyjKqsZP2/TR9lk3CKU5gsCAQCgDaIVc=; b=o4SLvSEZ2uDV15XORMyuRc2ldhP76eBgYIUPw0Mj2e1G8lk5zxHlGacz9J2GDNQ50u GkQ9i1/5b33Ef8LWHjO1qTNHdNDqIaM2BFu9x/1fHdFWJohEBr0j29e9XXYVbgOq0AOk xGK9iPLOJgrrDY2brXmLn5OpltrHpnHo/X7VSV24md/+Igbj82A/kBet7/oOKvQHDZcx X5FVaoXKXwPr14U7ocDHs7bUfLbs7wneziOShSR2I0HZEJCrlw8/WPQ+1lTPb5RvDOBU r4om8ePMWhWWZSzykIr3tnWrQWRRFoogzDpK/3hzR3m/2RuXzAUg9b6XGB0LLEkxQWr5 TQxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693946971; x=1694551771; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S6kVt6iBw47kyjKqsZP2/TR9lk3CKU5gsCAQCgDaIVc=; b=dhs0XgBJ3xGZ4DpnMNDN4PBIuAVp7PgxSNuwGMe/viVbROf0ZuJiruRXiHxKH6zuez rd99Nh3y9coD4J0KUjuLs8B2JBZvxBZh44pPLc63qDI/vk45SkqCTH07J+wdRUDnz33o JnV8i42O77Ot9UaIs+uCdOkyTHm3rBTLNSDsmTU9WB+l09t8WTg0EV+GQT1dhec1b/M3 2d+S/lAfCTwFexKyMrfx/ycYp/XuBMS11FOTKgrqbldTIsxjKPaJw6Oe7Aaxk+XUFY+D nGN/29Mwaz0oGecFmrUNYqfP0AWPoSDHzToytlfpaqzes9dJH1F+z6QDQYjq03xG43To Q7wg== X-Gm-Message-State: AOJu0YyIXOEJoh6M0KFVW5s5bAcv3dWkWVHqbGhZget/GyTJDnQdZQVi gsKrx++fIyqgoRyg0cJrnC6NQ627Plk= X-Google-Smtp-Source: AGHT+IHKP6ws2lUx2HIJT3aaR8ovf8Bsi5gm5rVKGOr1t+/FPc0aL/DiX6K5Hd1it3AeWs/OtwQIag== X-Received: by 2002:a17:902:f806:b0:1b5:64a4:bea0 with SMTP id ix6-20020a170902f80600b001b564a4bea0mr12362022plb.10.1693946970914; Tue, 05 Sep 2023 13:49:30 -0700 (PDT) Original-Received: from localhost (ip184-189-240-75.sb.sd.cox.net. [184.189.240.75]) by smtp.gmail.com with ESMTPSA id e21-20020a170902d39500b001b51b3e84cesm9744153pld.166.2023.09.05.13.49.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 13:49:30 -0700 (PDT) In-Reply-To: <255bb831-2309-764a-bb23-087ab267437b@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=karthikchikmagalur@gmail.com; helo=mail-pl1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310155 Archived-At: > > - :type '(restricted-sexp :match-alternatives (stringp symbolp > functionp consp)) > > - :group 'popper) > > + :type '(repeat (string :tag "Regular Expression") > > + (symbol :tag "Major Mode") > > + (function :tag "Predicate Function") > > + ;; What is the consp in (restricted-sexp :match-alternatives > (stringp symbolp functionp consp))? > > + )) > > The different alternatives should be inside a choice: > :type '(repeat (choice (string :tag "Regular Expression") > (symbol :tag "Major Mode") > (function :tag "Predicate Function")) In addition, cons cells of the form '(string-or-symbol . hide) are allowed. I'm not sure how to represent this in the customization types list. I'm okay with omitting this from the customize interface, since it's a niche option that few users will need. > > (defcustom popper-mode-line-position 0 > > "Position in mode-line to place `popper-mode-line'." > > - :type 'integer > > - :group 'popper) > > + :type 'natnum) > > IIUC, the package requires Emacs 26.1, and the natnum widget wasn't > available back then. Does Compat have it? Thanks for checking. I will revert the type to 'integer for now. Karthik