From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: package-vc support for :files keyword Date: Sun, 24 Sep 2023 16:31:27 +0200 Message-ID: <87wmwfbq2o.fsf@posteo.net> References: <87ttrshrib.fsf@hyperspace> <871qev6e53.fsf@posteo.net> <87r0mviltd.fsf@hyperspace> <871qevbhru.fsf@posteo.net> <87o7hzi82q.fsf@hyperspace> <87pm2ebldd.fsf@posteo.net> <87o7hyl01m.fsf@hyperspace> <87y1h18flc.fsf@posteo.net> <87jzsgm82h.fsf@hyperspace> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26436"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Tony Zorman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 24 16:32:22 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkQ9m-0006he-6h for ged-emacs-devel@m.gmane-mx.org; Sun, 24 Sep 2023 16:32:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qkQ90-000875-N4; Sun, 24 Sep 2023 10:31:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkQ8z-00084C-Bp for emacs-devel@gnu.org; Sun, 24 Sep 2023 10:31:33 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkQ8x-0001ET-F1 for emacs-devel@gnu.org; Sun, 24 Sep 2023 10:31:32 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 389CF240101 for ; Sun, 24 Sep 2023 16:31:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1695565888; bh=zoCoLo+0ue5wX6qy1hghZSF6jLMcC5sg1vCsZNEMUbk=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=iQAb1cKADV7uzzPvsePZ6jd+uorr+TjvfnkPTaHNxkZRAfsY7x07ao5fl6zeiGZiS 9OX9Ocl5tUmRkRSCPZ3XTuWv47DX9uNGwiHJLYSQVwKQnpeT6bd6p+NFNSG7TzTbT4 Inh1iRLzKVD7kGWF4W1aOYSQlcQeYTmKARU+6TMlml88iPHHd6G4A4W37MGd7mAoSm c7ERUYyuzqrwOxBFiZuMEkKJfi/FVMBBsnxFy5R0wRsHGlocZ26Lz9GBa/aaDRcQgg /DMN2QWNuPuJmnEXnRDYl4iUZ360V2f3urcdMINiL7raumM7LDiO0A1P77Ooq79u0X fk/B0WfmdY7yA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RtpNH5Y2yz9rxB; Sun, 24 Sep 2023 16:31:27 +0200 (CEST) In-Reply-To: <87jzsgm82h.fsf@hyperspace> (Tony Zorman's message of "Sun, 24 Sep 2023 07:52:38 +0200") X-Hashcash: 1:20:230924:tonyzorman@mailbox.org::hxPPfER7bBEg+b39:3XxF Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311025 Archived-At: Tony Zorman writes: > On Wed, Sep 20 2023 07:32, Philip Kaludercic wrote: >> + (unless (string-match-p ignored-files file) > > One thing that did jump out to me just now, which I hadn't considered > before: when ignored-files is the empty string, this will always match > any file=E2=80=94not what we want :) Do you mean because the empty glob expression doesn't match everything, but the empty regular expression does? The easiest solution seems to be to just check if the empty string is listed and handle that separately (whatever the correct behaviour is in that case), but on the other hand, why should a user list an empty string in the list of ignored files? --=20 Philip Kaludercic