From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Make ispell localwords safe local variable Date: Thu, 30 Nov 2023 22:56:45 -0800 Message-ID: <87wmtyv21h.fsf@breatheoutbreathe.in> References: <87zg2s97x0.fsf@breatheoutbreathe.in> <83o7j8a59k.fsf@gnu.org> <87h6ozdalc.fsf@breatheoutbreathe.in> <83jztv89gi.fsf@gnu.org> <83wmxikyuk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14538"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 01 08:53:38 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r8yLB-0003Xs-6u for ged-emacs-devel@m.gmane-mx.org; Fri, 01 Dec 2023 08:53:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8yKX-0001GY-IP; Fri, 01 Dec 2023 02:52:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8xXS-0007m5-V1 for emacs-devel@gnu.org; Fri, 01 Dec 2023 02:02:15 -0500 Original-Received: from out-180.mta1.migadu.com ([2001:41d0:203:375::b4]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8xXR-0007u0-2e for emacs-devel@gnu.org; Fri, 01 Dec 2023 02:02:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1701414126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tR1IDQ2Qpz/p4+/Ai+KxLYcovkVQoKaKbxLNHpYqucg=; b=RKPpecYaMHedIi0QRPJb/nsPam2q2naATgfTyxpvulAp3qPf3hQg0HQ4ff/xOVnVjO0vDX 2TP7f+jNmlf6Agg7gPeEgBxPem0yj7lO1CAFigHYWQ5LpCWdBaj+lIscBKEmABPaeRd7YZ 2BNyFRIUQNMOR2aQRrjnr9HyZZftrkE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <83wmxikyuk.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:203:375::b4; envelope-from=joseph@breatheoutbreathe.in; helo=out-180.mta1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 01 Dec 2023 02:52:56 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313422 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: > It sounds like no one sees a problem with this change, so I've now > installed it on the master branch. Would you be willing to merge the same commit on the emacs-29 branch? If ispell-buffer-session-localwords is not safe, then package-vc-install fails to install packages which set it in a dir-locals.el. This is currently the case with hyperdrive.el, whose manual recommends that users mark it as safe in their own configuration prior to installation. (put 'ispell-buffer-session-localwords 'safe-local-variable #'list-of-strings-p) It's a minor change, but worth asking for. Thank you!!! Joseph --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Make-ispell-localwords-safe-local-variable.patch >From ae3c7031ed7471900b0ae27eff4ccfb04fd7f597 Mon Sep 17 00:00:00 2001 From: Joseph Turner Date: Thu, 30 Nov 2023 22:50:29 -0800 Subject: [PATCH] Make ispell localwords safe local variable * lisp/textmodes/ispell.el (ispell-buffer-session-localwords): Make safe local variable to so that checkdoc can ignore words in a project in batch mode. Do not merge to master. --- lisp/textmodes/ispell.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/textmodes/ispell.el b/lisp/textmodes/ispell.el index 48d48b07937..b71e85b0e37 100644 --- a/lisp/textmodes/ispell.el +++ b/lisp/textmodes/ispell.el @@ -1747,6 +1747,7 @@ Ispell is then restarted because the local words could conflict.") (defvar-local ispell-buffer-session-localwords nil "List of words accepted for session in this buffer.") +(put 'ispell-buffer-session-localwords 'safe-local-variable #'list-of-strings-p) (defvar ispell-parser 'use-mode-name "Indicates whether ispell should parse the current buffer as TeX Code. -- 2.41.0 --=-=-=--