From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470) Date: Sun, 21 Jan 2024 19:16:31 +0100 Message-ID: <87wms24kn4.fsf@gmx.de> References: <170030013667.20571.18090141972402319489@vcs2.savannah.gnu.org> <20231118093537.9F147C0C994@vcs2.savannah.gnu.org> <87a5p1679r.fsf@gmx.de> <83a5p0til9.fsf@gnu.org> <87a5oz0w8b.fsf@gmx.de> <87ttn6rfre.fsf@zohomail.eu> <877ck26cuu.fsf@gmx.de> <87plxuravt.fsf@zohomail.eu> <87le8ira14.fsf@zohomail.eu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25359"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Rahguzar Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 21 19:17:10 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rRcNa-0006MV-Ch for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Jan 2024 19:17:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rRcN4-0001e4-SL; Sun, 21 Jan 2024 13:16:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRcN2-0001db-Pn for emacs-devel@gnu.org; Sun, 21 Jan 2024 13:16:36 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRcN0-0000e3-Na; Sun, 21 Jan 2024 13:16:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1705860991; x=1706465791; i=michael.albinus@gmx.de; bh=TcA02ZMx5t8IPfmsNbmBWa0MYdLvH04LZ1eXwRs6Gs4=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=LkKLdPgRf7r6UlWk+vSQY1cKMsQp9XzYqYdHYkTDTX4UoJq6Y6ELxx9uVe6ewGvr hmsh4Baf3X5FqtIBW/xZzz0UpHMKGpCZu6qgVY+5xVJzFm4iBcujq2O7joBLV6C/F UKtn9Ann38nsX5f+IPeRNMfHplFpbg0TMnmDOtN2xk2OOUTvLsGo90tvJoTRNhfXZ 07jjh3tJjsnIp25mv6RZRckVikkLFQbILP6T/qBsrfRJujFX7NU9jh212Fkp5eZa9 0uRQ40pt4HX1dch0+4QIBWJZGh5viOPuMSc59DNixE3GY4iRBov+7HE9e5BStNdYi 1wz7h1I8QxUCbK5G0w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N63Ra-1r3UrX2qPg-016LNM; Sun, 21 Jan 2024 19:16:31 +0100 In-Reply-To: <87le8ira14.fsf@zohomail.eu> (rahguzar@zohomail.eu's message of "Sun, 21 Jan 2024 16:07:31 +0100") X-Provags-ID: V03:K1:WX8+imJO122vO+gOAXIDbj+N5C5yW4Bwl+5ouJUt/LiuhjfkCW9 paQTG+n1F7AmeISGxhrpArRhTJSq9JDIQcm8mFB0i87ZvNUozS0acrne54onmaR4BCRnayg MDHNTrS9iHGxIti1/KmOuplS3PaRGFTW87ROkszop+inCy7OwQOv9JTpFbhgWADlfpfRc2u X5dwdmb2cZXWHN8nn/Euw== UI-OutboundReport: notjunk:1;M01:P0:oR1w9F4VY5M=;0USLGY8SqHH7A8HGuQUusJN+a8E nQz+MS1xjyYrfpTlijjV34MaGdU3wByprwDNu1Bicxa9m8cGptY0fCIBLLLCkgMWlRqmGskd2 3l8OK4zIKSVZ2SarGPGOW0FqYEtcgQO2wPriawIk0zYn10kt/CssKgDwc5XSnD30vXzhZP3Zh blEsZeshcu4j9d9hSTDjhF+UWi0urfF6f7roqhjd90PVbrK3Fpi2jFzZly3BwcMu4HFsBMQaD wS5f7hagIbZ7v/jAiPfvM9DKPArRNWJLUyHD6LizLBed+0wbnm4CzojKIKkyi9okQihSXTBeJ LtmChuhNYEY0AxuwnxCjD/vDlGEeFVnH0d7i1lnZ19veIHa8w5KZqCW/lKCz+FfPsR9/hwt8L 5e7yxSuqTmr/4tcHtE1oncd/iQk3T4LAbpBHewDEDERd8PAh10H7AMk4r2FNY13/S8DAJ2TzK vx+5lalNmPsL+EpCaXBu9UBovzBRLBGh8E7dj91Ia1FDtuWv6/KDa7EhJ0MdIQTATr2jt7qgl eXkE8MbQ0isqB3B3zSTVJvn3yLZzjtNwrkd6XS4hTvxnG2eTvP9bSTB9nALO1CBwh4rBoWYCD jSeXeFusOGG/hDpQwZFGbE6Y3upJnkM9t4vtMF6xGApRQPmz5kiNCtkc93plsZ2xrbLcrfQ2B YqTiAudhtVbMd+LRIW0B79NQ8gec0LIu2tpUl7eEqBVu7R+eDebWg4vR87Qc03ZW4EIFBnOnI KmfVKG0mgfj7o4S5bxEN3p9g3H1ppBZANfhXJrSlGBm5W75f9TdQD59Kla4g/WYjHo6OWHHk Received-SPF: pass client-ip=212.227.15.19; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315188 Archived-At: --=-=-= Content-Type: text/plain Rahguzar writes: Hi Rahguzar, > Actually I see what is happening now. `cus-test-deps` is checking if it > can load the files defining the custom variables. None of the files in > lisp/leim/quail are on the load path. The cases where require succeeds > it is because some other file with the same file-name-non-directory is > on the load path e.g. for indian.el it is, > > lisp/language/indian.el > > which does not define any custom variable. > > I think the problem is with the test. Good catch! One possible solution is to add the quail/ subdirectory to load-path, temporarily. Like this: --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/admin/cus-test.el b/admin/cus-test.el index b86643a769a..96f0c1ff0c4 100644 --- a/admin/cus-test.el +++ b/admin/cus-test.el @@ -424,7 +424,12 @@ cus-test-deps (mapatoms ;; This code is mainly from `custom-load-symbol'. (lambda (symbol) - (let ((custom-load-recursion t)) + (let ((custom-load-recursion t) + (load-path + (cons + (expand-file-name + "quail" (file-name-directory (locate-library leim-list-file-name))) + load-path))) (dolist (load (get symbol 'custom-loads)) (cond ((symbolp load) --=-=-= Content-Type: text/plain Likely there are also other solutions, don't know what's the best. Eli? > P.S. Both lisp/leim/quail/indian.el and lisp/language/indian.el provide > the feature indian which doesn't seem like the right thing. Yes, that's unfortune. Another minor annoyance is, that `tamil-input' of lisp/leim/quail/indian.el and `pakistan-urdu-input' of lisp/leim/quail/pakistan.el have different parent groups, `leim' and `quail'. Shouldn't this be `quail' in both cases? > Rahguzar writes: Best regards, Michael. --=-=-=--