Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470)

[Michael Albinus <michael.albinus@gmx.de>]

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

Rahguzar <rahguzar@zohomail.eu> writes:

Hi Rahguzar,

> Actually I see what is happening now. `cus-test-deps` is checking if it
> can load the files defining the custom variables. None of the files in
> lisp/leim/quail are on the load path. The cases where require succeeds
> it is because some other file with the same file-name-non-directory is
> on the load path e.g. for indian.el it is,
>
> lisp/language/indian.el
>
> which does not define any custom variable.
>
> I think the problem is with the test.

Good catch! One possible solution is to add the quail/ subdirectory to
load-path, temporarily. Like this:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 600 bytes --]

diff --git a/admin/cus-test.el b/admin/cus-test.el
index b86643a769a..96f0c1ff0c4 100644
--- a/admin/cus-test.el
+++ b/admin/cus-test.el
@@ -424,7 +424,12 @@ cus-test-deps
   (mapatoms
    ;; This code is mainly from `custom-load-symbol'.
    (lambda (symbol)
-     (let ((custom-load-recursion t))
+     (let ((custom-load-recursion t)
+           (load-path
+            (cons
+             (expand-file-name
+              "quail" (file-name-directory (locate-library leim-list-file-name)))
+             load-path)))
        (dolist (load (get symbol 'custom-loads))
 	 (cond
 	  ((symbolp load)

[-- Attachment #3: Type: text/plain, Size: 526 bytes --]


Likely there are also other solutions, don't know what's the best. Eli?

> P.S. Both lisp/leim/quail/indian.el and lisp/language/indian.el provide
> the feature indian which doesn't seem like the right thing.

Yes, that's unfortune.

Another minor annoyance is, that `tamil-input' of
lisp/leim/quail/indian.el and `pakistan-urdu-input' of
lisp/leim/quail/pakistan.el have different parent groups, `leim' and
`quail'. Shouldn't this be `quail' in both cases?

> Rahguzar <rahguzar@zohomail.eu> writes:

Best regards, Michael.